New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify docs into annotations #53

Merged
merged 7 commits into from Aug 20, 2016

Conversation

Projects
None yet
3 participants
@Kroisse
Contributor

Kroisse commented Aug 17, 2016

This PR suggests to unify internal representations of doc comments and the annotation set, by treat doc comments as a @doc("...") annotation.

import Nirum.Constructs.Name (Name)
annotationDocsName :: Identifier
annotationDocsName = "doc"

This comment has been minimized.

@dahlia

dahlia Aug 17, 2016

Member

"doc" 대신 "docs"를 쓰면 어떨까요?

@dahlia

This comment has been minimized.

Member

dahlia commented Aug 17, 2016

Declaration 타입 클래스의 docs 함수에 기본 구현을 추가하면 좋을 것 같긴 한데, 그건 Declaration 타입 클래스에 annotations 함수 먼저 추가한 뒤에 생각해봐야겠군요…

@dahlia dahlia added the typ:enhance label Aug 17, 2016

@dahlia

This comment has been minimized.

Member

dahlia commented Aug 17, 2016

@admire93 님도 봐주세요.

@Kroisse

This comment has been minimized.

Contributor

Kroisse commented Aug 17, 2016

@dahlia 네. 지금 annotation이 붙지 않는 다른 요소들에도 전부 annotation을 붙일 수 있게 되면 그렇게 해 보려고 생각중입니다... 가 아니라 지금도 할 수 있겠군요.

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Aug 18, 2016

확인했습니다. 이제 @docs로 붙이는거군요. 그나저나 conflict 가..

@dahlia

This comment has been minimized.

Member

dahlia commented Aug 18, 2016

충돌이 있네요. 리베이스 부탁드립니다.

@dahlia dahlia merged commit 9b6313a into nirum-lang:master Aug 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment