Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan status tooltip #96

Merged
merged 3 commits into from
Nov 11, 2014
Merged

Plan status tooltip #96

merged 3 commits into from
Nov 11, 2014

Conversation

florpor
Copy link
Collaborator

@florpor florpor commented Nov 10, 2014

No description provided.

@florpor
Copy link
Collaborator Author

florpor commented Nov 10, 2014

well, i can go for a dictionary.
but i think a seperate file is too much, this function is not big and i feel seperating this will be more confusing than helpful..

@niryariv
Copy link
Owner

the reason for separating is that this is really data or config (kind of like munis.js) rather than core code -
ie, I expect to edit this now and then to change/fix/translate the texts - so it should be in a different place than our actual core code

@florpor
Copy link
Collaborator Author

florpor commented Nov 10, 2014

so how bout i put it at top of the file out of the function?
another file = another http request every time someone loads the site, which all go through our poor proxy.

@niryariv
Copy link
Owner

how many requests go through the proxy now in a typical page? perhaps we should explicitly use the github.io domain when all the non-index.html files

@florpor
Copy link
Collaborator Author

florpor commented Nov 11, 2014

right now we have (if i counted right) 26 http requests through our proxy per page load.
after the first load (per municipality) many of them are 304 unchanged which doesn't strain us so much.
we can use full github.io urls for scripts and such, but that will make some cors problems and would make the code much harder to debug (we had this with the spa idea if i remember right).
thing is - javascript resources that have different dev and production environments can afford to be super seperated and structured, such as jquery, which in development has tens of js files, but when is made for production is all crammed into one.
we don't seperate our dev and prod, and so i think this is just an overkill and unnecessary. it takes 2 minutes to find where this is in our code if you know our basic structure with handlebars, and (for now) this is just one dictionary which is coupled with one function.

@niryariv
Copy link
Owner

ok, please create a PR with the dictionary and we'll merge

@florpor
Copy link
Collaborator Author

florpor commented Nov 11, 2014

done

niryariv added a commit that referenced this pull request Nov 11, 2014
@niryariv niryariv merged commit eae836f into master Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants