Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gravatars should work through the HTTPS if site works through the HTTPS as well #49

Closed
oduvan opened this issue May 25, 2015 · 5 comments
Closed

Gravatars should work through the HTTPS if site works through the HTTPS as well #49

oduvan opened this issue May 25, 2015 · 5 comments

Comments

@oduvan
Copy link

oduvan commented May 25, 2015

When I use Spirit on site with https browser shows me an alert that avatars have been loaded from http
@nitely
Copy link
Owner

nitely commented May 25, 2015

Any reason why it should not always use https?

@oduvan
Copy link
Author

oduvan commented May 26, 2015

Actually agree . it should always HTTPS. Right now it is always HTTP

@oduvan
Copy link
Author

oduvan commented May 26, 2015

thanks

@oduvan
Copy link
Author

oduvan commented May 26, 2015

You did a fix into experimental branch. Not it master?

Which branch should I use on production?

@nitely
Copy link
Owner

nitely commented May 26, 2015

You should use the master branch. The experimental branch will get merged at some point.

@nitely nitely closed this as completed in 9f2c30e Jul 28, 2015
Macbull pushed a commit to Macbull/Spirit that referenced this issue Aug 11, 2015
@nitely
gravatar http to https, fix nitely#49
afab5e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oduvan @nitely