Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'link' control not working as expected (mui-rte: v 1.11.0) #72

Closed
corneliugaina opened this issue Jan 20, 2020 · 5 comments
Closed

'link' control not working as expected (mui-rte: v 1.11.0) #72

corneliugaina opened this issue Jan 20, 2020 · 5 comments

Comments

@corneliugaina
Copy link

corneliugaina commented Jan 20, 2020

Hello, at first thank you for this MUI/Draft.js library.

At first I stumbled on a bug ..

I wonder how to use (or create) the link embedded control ? You provide it but I cannot figure how to use it. The button link doesn't do anything.

... then I find out (maybe why).

You provide a basic example on Codesandbox which is on mui-rte 1.11.0. I think that the bug is related to this last version. cf. : https://codesandbox.io/s/mui-rte-basic-ypfdo?fontsize=14

We figure out that v. 1.9.3 works fine. The bug must lies somewhere in the toolbar (cf. release note 1.10), I think that maybe the popover position isn't correctly initialized.

Have a nice day.

@corneliugaina corneliugaina changed the title "link" embedded control 'link' control not working as expected (mui-rte: v 1.9.3) Jan 21, 2020
@corneliugaina corneliugaina changed the title 'link' control not working as expected (mui-rte: v 1.9.3) 'link' control not working as expected (mui-rte: v 1.11.0) Jan 21, 2020
@niuware
Copy link
Owner

niuware commented Jan 22, 2020

Hi @corneliushka,
Thank you for the heads up, I will fix this soon.

@niuware niuware mentioned this issue Feb 11, 2020
@niuware
Copy link
Owner

niuware commented Feb 11, 2020

@corneliushka Fixed on version 1.12.0 :)

@niuware niuware closed this as completed Feb 11, 2020
@p08kast
Copy link

p08kast commented Jan 25, 2022

We are facing a similar issue. We use mui-rte v.2.0.1 with material 5.1. We render the rte within a modal that is inside an iframe. While everything else works as expected, clicking the linking button on the toolbar does absolutely nothing.

@corneliushka what was the initial reason you mention in your original post?

Btw, the sandbox provided is working just fine for me.

@corneliugaina
Copy link
Author

corneliugaina commented Jan 25, 2022

@p08kast My original post pointed a bug with the demo (and production code on some version) where the prompt of linking wasn't working.

Speaking of your issue, I suspect that your modal "hides" the popup because of z-index of something like that. Beware that in MUI (4 or 5), the components have a standard zIndex that you can override of course in your custom theme.

Try just to render you component outside of the modal/dialog/popup, just to be sure that it's about this. Otherwise I didn't yet use mui-rte with MUI5 but there's some issues and update about this. Didn't investigated

mui z-index docs

@p08kast
Copy link

p08kast commented Jan 25, 2022

I am aware of the z-index issues, however the popover doesn't seem to be appended in the DOM at all. I've also tried setting disablePortal to true in case it was being appended outside my iframe but to no avail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants