-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use systemd tray.target
#3432
base: master
Are you sure you want to change the base?
Use systemd tray.target
#3432
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@@ -199,7 +199,7 @@ in { | |||
|
|||
systemd.target = mkOption { | |||
type = str; | |||
default = "graphical-session.target"; | |||
default = "tray.target"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this racy?
Other services could also start as they might be wanted by tray.target
, before waybar has even initialized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess short of having those services instead depend on waybar.service
, you'd have to create a tray-pre.target
, which would make sense to me if people are pinning tasks that go into a tray to tray.target
, and they as such need a tray service to pre-exist to put it in.
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
Description
This make
waybar
systemd
unit to be part oftray.target
. So it's uniform with the other bars and make working with tray applets easier. Related changes to other bars: 4f70f49Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS
.