Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use systemd tray.target #3432

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

budimanjojo
Copy link

Description

This make waybar systemd unit to be part of tray.target. So it's uniform with the other bars and make working with tray applets easier. Related changes to other bars: 4f70f49

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@teto teto added the systemd label Nov 30, 2022
@stale

This comment was marked as outdated.

@stale stale bot added the status: stale label Mar 1, 2023
@@ -199,7 +199,7 @@ in {

systemd.target = mkOption {
type = str;
default = "graphical-session.target";
default = "tray.target";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this racy?
Other services could also start as they might be wanted by tray.target, before waybar has even initialized.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess short of having those services instead depend on waybar.service, you'd have to create a tray-pre.target, which would make sense to me if people are pinning tasks that go into a tray to tray.target, and they as such need a tray service to pre-exist to put it in.

@stale stale bot removed status: stale labels Mar 1, 2023
@stale
Copy link

stale bot commented Aug 6, 2023

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants