kakoune: use str for hooks and check configuration #3537
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up on #3418.
The aim is to turn kakoune hooks into a string instead of an enum to avoid having to update them when they change in kakoune.
And to validate that the string value is correct, the idea was to add a configuration checker in the checkPhase.
However, I struggled to correctly implement the checker as kakoune does not have a simple way to validate the configuration.
See my comment for more details: #3418 (comment)
As I am not using kakoune anymore, I am simply creating this PR to reference the WIP that has been done, in case someone wants to continue working on this.
I will be directly closing the PR, but feel free to comment if you are interested.