Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kakoune: use str for hooks and check configuration #3537

Closed
wants to merge 1 commit into from

Conversation

lobre
Copy link
Contributor

@lobre lobre commented Dec 29, 2022

Description

This is a follow-up on #3418.

The aim is to turn kakoune hooks into a string instead of an enum to avoid having to update them when they change in kakoune.

And to validate that the string value is correct, the idea was to add a configuration checker in the checkPhase.

However, I struggled to correctly implement the checker as kakoune does not have a simple way to validate the configuration.

See my comment for more details: #3418 (comment)

As I am not using kakoune anymore, I am simply creating this PR to reference the WIP that has been done, in case someone wants to continue working on this.

I will be directly closing the PR, but feel free to comment if you are interested.

@lobre
Copy link
Contributor Author

lobre commented Dec 29, 2022

As said above, closing. Feel free to comment if you want to pick it up.

@lobre lobre closed this Dec 29, 2022
@lobre lobre mentioned this pull request Dec 29, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant