-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpg-agent: don't set a default for pinentry #4805
Conversation
Couldn't using |
I have no idea. I am using kde, so for me this will obviously work but I have no clue about other systems. |
NixOS stopped building gtk2 pinentry by default in NixOS/nixpkgs#270266 and there does not appear to be a reasonable other default.
Thanks! Merged to master now 🙂 I wonder if perhaps it wouldn't be a good idea to simply remove the |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/pinentry-gtk2-contains-only-pinentry-curses/37696/5 |
This was missed in [1], but we should remove the default for the same reason... [1]: nix-community#4805
This was missed in [1], but we should change the default for the same reason... [1]: nix-community#4805
Is there any official guide on how to upgrade the existing home-manager setups? I use both NixOS (X11 Plasma) and MacOS and the original setup was compatible with both (as I do not do anything system wide in MacOS). In my case, I was able to sign my commits under both systems but now I cannot. From what I read the gtk2 is very much deprecated. (This threw me off while I was upgrading some packages - the price to pay for following |
NixOS stopped building gtk2 pinentry by default in NixOS/nixpkgs#270266 and it does not appear to me that there is a reasonable other default.
Description
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC