New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "pinentry: drop gtk2" #276143
Revert "pinentry: drop gtk2" #276143
Conversation
This reverts commit edb8b79.
Why would you want to still use it? It is since 3 years deprecated and there is no DE using it anymore. |
It's the default in home-manager:
That's probably worth changing anyway, but in the meantime let's bring back the gtk2 pinentry. |
I am not very amused that we are held back by an out of tree project that is setting bad defaults and not properly forwarding the overrides. I've opened nix-community/home-manager#4805. Lets see how far we get with that instead of undoing this. |
I think this also affects
(I may look at outdated code, I have EDIT: Actually, there seem to be more problems with |
For wayland folks, gave wayprompt a try. It's pretty good, but it's only in nixpkgs-wayland. Would appreciate if anyone can upstream the package in nixpkgs. |
@dschrempf I've opened #277221 to fix that. I hope I didn't mix things up. The linked home-manager PR got merged, so we can close this, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth noting that the prior PR also silently broke the top-level attribute pkgs.pinentry-gtk2. Unless gtk2 itself is removed from nixpkgs I don't see why this shouldn't continue to be available, and if it is a bottleneck for builds then a separate derivation could be provided as a middle-ground solution instead.
It is just no longer available as a default, you can still explicitly opt into this.
I don't think we need to go that way. gpg pinentry is pretty small and pretty fast built. |
No, #270266 broke this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this since there is no use keeping gtk2 broken while #277221 is no ready.
This reverts commit edb8b79.
Description of changes
Revert the removal of the gtk2 flavour in #270266, since people are still using the gtk2 pinentry for reasons.
gtk2 still won't end up in the runtime closure of systems not using it, but something like #133542 might be a more principled approach that removes it from the build-time closure too.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.