Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add override for panel, imagecodecs #100

Merged
merged 1 commit into from May 9, 2020

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented May 7, 2020

Note that imagecodecs override depends on NixOS/nixpkgs#87205.

Also, should such large overrides go into this single file? I could see this getting out of hand quickly as it somewhat duplicates nixpkgs for complicated packages...

@adisbladis
Copy link
Member

Also, should such large overrides go into this single file?

I think we're about reaching the breaking point where the single file approach is no longer viable and this should be split up.
For this PR let's stick with the single file and let me clean up afterwards.

@adisbladis
Copy link
Member

I made two fixups:

  • You were mixing nativeBuildInputs and buildInputs when creating the overriden buildInputs.
  • The use of with is not allowed in poetry2nix, so I've explicitly added pkgs. before each input.

@adisbladis adisbladis merged commit 1cfaa40 into nix-community:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants