overrides: add fixups for vllm's both wheel and source mode #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR partially fixes #1553 |
Atry
changed the title
cpcloud
reviewed
May 1, 2024
cpcloud
reviewed
May 1, 2024
cpcloud
reviewed
May 1, 2024
|
@cpcloud The test failure seems not due to this PR |
cpcloud
reviewed
May 4, 2024
cpcloud
force-pushed
the
patch-1
branch
2 times, most recently
from
bd45156
to
2736ad4
Compare
[vllm](https://github.com/vllm-project/vllm) is a popular server for LLM inference. 1. `autoPatchelfIgnoreMissingDeps` is set for CUDA shared libraries, similar to existing `xxx-cu11` packages. 2. `lib.optionalAttrs (!old.src.isWheel)` are added for the existing fixups that are not compatible with wheels.
cpcloud
approved these changes
May 5, 2024
|
vllm 0.3.3 works, but 0.4.1 crashes #1635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution checklist (recommended but not always applicable/required):