Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-operations): Depends on Cython 0 #1658

Merged
merged 1 commit into from
May 25, 2024
Merged

fix(color-operations): Depends on Cython 0 #1658

merged 1 commit into from
May 25, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented May 15, 2024 •
edited
Loading

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

l0b0 added a commit to linz/emergency-management-tools that referenced this pull request May 15, 2024
@l0b0
build: Bump Python packages
5f9ff8c 
Challenges:

- Upgrade GDAL to <3.9 because of
   <NixOS/nixpkgs#311310>.
- Upgrade numexpr to <2.10 because of
   <NixOS/nixpkgs#310837>.
- Had to add Cython 0 to the color-operations build inputs
   <nix-community/poetry2nix#1658>
@l0b0 l0b0 mentioned this pull request May 15, 2024
Open
l0b0 added a commit to linz/emergency-management-tools that referenced this pull request May 23, 2024
@l0b0
build: Bump Python packages
edc4d63 
Challenges:

- Had to hold back GDAL from 3.9 because it's not yet in nixpkgs
   <NixOS/nixpkgs#311310>.
- Had to hold back numexpr from 2.10 because it's not yet in nixpkgs
   <NixOS/nixpkgs#310837>.
- Had to hold back matplotlib from 3.9 because it needs a poetry2nix
   override <nix-community/poetry2nix#1659>.
- Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to
   0.1.0.
- Had to add Cython 0 to the color-operations build inputs
   <nix-community/poetry2nix#1658>.

Script:

```bash
cd flooding/sentinel2_water_extraction
poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
cd ../sentinel1_water_extraction/
poetry add --lock gdal="<3.9"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
```
l0b0 added a commit to linz/emergency-management-tools that referenced this pull request May 23, 2024
@l0b0
build: Bump Python packages
08bccd1 
Challenges:

- Had to hold back GDAL from 3.9 because it's not yet in nixpkgs
   <NixOS/nixpkgs#311310>.
- Had to hold back numexpr from 2.10 because it's not yet in nixpkgs
   <NixOS/nixpkgs#310837>.
- Had to hold back matplotlib from 3.9 because it needs a poetry2nix
   override <nix-community/poetry2nix#1659>.
- Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to
   0.1.0.
- Had to add Cython 0 to the color-operations build inputs
   <nix-community/poetry2nix#1658>.

Script:

```bash
cd flooding/sentinel2_water_extraction
poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
cd ../sentinel1_water_extraction/
poetry add --lock gdal="<3.9"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
```
@cpcloud cpcloud merged commit cd4e2b3 into nix-community:master May 25, 2024
163 checks passed
@l0b0 l0b0 deleted the fix/color-operations branch June 20, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@l0b0 @cpcloud