Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal: 3.8.5 -> 3.9.0 #311310

Merged
merged 5 commits into from
Jun 17, 2024
Merged

gdal: 3.8.5 -> 3.9.0 #311310

merged 5 commits into from
Jun 17, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented May 13, 2024

Description of changes

Update GDAL to the latest version.

Release notes: https://github.com/OSGeo/gdal/blob/v3.9.0/NEWS.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@imincik
Copy link
Contributor Author

imincik commented May 13, 2024

test_bag_write_values_at_nodata test is failing

_____________ ERROR at teardown of test_bag_write_values_at_nodata _____________

    @pytest.fixture(autouse=True, scope="module")
    def check_no_file_leaks():
        num_files = len(gdaltest.get_opened_files())

        yield

        diff = len(gdaltest.get_opened_files()) - num_files
        if diff != 0 and "CI" in os.environ:
            print("Leak of file handles: %d leaked. Flaky on CI, so ignored" % diff)
        else:
>           assert diff == 0, "Leak of file handles: %d leaked" % diff
E           AssertionError: Leak of file handles: -1 leaked
E           assert -1 == 0

@imincik
Copy link
Contributor Author

imincik commented May 13, 2024

Result of nixpkgs-review pr 311310 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
75 packages failed to build:
  • apacheHttpdPackages.mod_tile
  • cloudcompare
  • entwine
  • gdal (python311Packages.gdal)
  • gmt
  • gplates
  • grass
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • sumo
  • t-rex
  • udig
  • vpv
31 packages built:
  • gdalMinimal
  • mysql-workbench
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresql15JitPackages.postgis
  • postgresql15JitPackages.postgis.doc
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.gdal
  • pytrainer
  • pytrainer.dist

l0b0 added a commit to linz/emergency-management-tools that referenced this pull request May 15, 2024
Challenges:

- Upgrade GDAL to <3.9 because of
   <NixOS/nixpkgs#311310>.
- Upgrade numexpr to <2.10 because of
   <NixOS/nixpkgs#310837>.
- Had to add Cython 0 to the color-operations build inputs
   <nix-community/poetry2nix#1658>
@risicle
Copy link
Contributor

risicle commented May 21, 2024

What is the status of this? I see lots of failures in your build report.

Would be nice to get this in 24.05, but branch-off is imminent.

@imincik
Copy link
Contributor Author

imincik commented May 22, 2024

What is the status of this? I see lots of failures in your build report.

Would be nice to get this in 24.05, but branch-off is imminent.

Too many packages failed to build - mostly tests are failing. I think we can't get it in to 24.05.

@imincik
Copy link
Contributor Author

imincik commented May 22, 2024

Result of nixpkgs-review pr 311310 run on x86_64-linux 1

6 packages marked as broken and skipped:
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
  • worldengine-cli
  • worldengine-cli.dist
41 packages failed to build:
  • apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
  • cloudcompare
  • entwine
  • grass
  • pdal
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • qgis
  • qgis-ltr
67 packages built:
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • haskellPackages.hgdal
  • haskellPackages.hgdal.doc
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresqlJitPackages.postgis (postgresql15JitPackages.postgis)
  • postgresqlJitPackages.postgis.doc (postgresql15JitPackages.postgis.doc)
  • postgresqlPackages.postgis (postgresql15Packages.postgis)
  • postgresqlPackages.postgis.doc (postgresql15Packages.postgis.doc)
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.gdal
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • pytrainer
  • pytrainer.dist
  • qmapshack
  • saga
  • sumo
  • t-rex
  • udig
  • vpv

Logs

 42/129 Test  #42: pdal_io_ogr_writer_test ......................***Failed    5.75 sec                                                                                                                                                        │
│[==========] Running 15 tests from 1 test suite.                                                                                                                                                                                              │
│[----------] Global test environment set-up.                                                                                                                                                                                                  │
│[----------] 15 tests from OGRWriterTest                                                                                                                                                                                                      │
│[ RUN      ] OGRWriterTest.shapefile                                                                                                                                                                                                          │
│[       OK ] OGRWriterTest.shapefile (421 ms)                                                                                                                                                                                                 │
│[ RUN      ] OGRWriterTest.json                                                                                                                                                                                                               │
│[       OK ] OGRWriterTest.json (431 ms)                                                                                                                                                                                                      │
│[ RUN      ] OGRWriterTest.geopackage                                                                                                                                                                                                         │
│[       OK ] OGRWriterTest.geopackage (448 ms)                                                                                                                                                                                                │
│[ RUN      ] OGRWriterTest.creation_options                                                                                                                                                                                                   │
│/build/source/test/unit/io/OGRWriterTest.cpp:121: Failure                                                                                                                                                                                     │
│Expected equality of these values:                                                                                                                                                                                                            │
│  compare(infofile, outinfofile, 1)                                                                                                                                                                                                           │
│    Which is: 4                                                                                                                                                                                                                               │
│  0                                                                                                                                                                                                                                           │
│  (/build/source/test/data/ogr/creation_options.geojson.ogrinfo <-> /build/source/test/data/../temp/ogr/creation_options.geojson.ogrinfo)                                                                                                     │
│[  FAILED  ] OGRWriterTest.creation_options (487 ms)                                                                                                                                                                                          │
│[ RUN      ] OGRWriterTest.shapefile_measure                                                                                                                                                                                                  │
│[       OK ] OGRWriterTest.shapefile_measure (623 ms)                                                                                                                                                                                         │
│[ RUN      ] OGRWriterTest.attrs_all                                                                                                                                                                                                          │
│[       OK ] OGRWriterTest.attrs_all (583 ms)                                                                                                                                                                                                 │
│[ RUN      ] OGRWriterTest.geopackage_attrs_all                                                                                                                                                                                               │
│/build/source/test/unit/io/OGRWriterTest.cpp:121: Failure                                                                                                                                                                                     │
│Expected equality of these values:                                                                                                                                                                                                            │
│  compare(infofile, outinfofile, 1)                                                                                                                                                                                                           │
│    Which is: 237                                                                                                                                                                                                                             │
│  0                                                                                                                                                                                                                                           │
│  (/build/source/test/data/ogr/geopackage_attrs_all.gpkg.ogrinfo <-> /build/source/test/data/../temp/ogr/geopackage_attrs_all.gpkg.ogrinfo)                                                                                                   │
│[  FAILED  ] OGRWriterTest.geopackage_attrs_all (273 ms)                                                                                                             

l0b0 added a commit to linz/emergency-management-tools that referenced this pull request May 23, 2024
Challenges:

- Had to hold back GDAL from 3.9 because it's not yet in nixpkgs
   <NixOS/nixpkgs#311310>.
- Had to hold back numexpr from 2.10 because it's not yet in nixpkgs
   <NixOS/nixpkgs#310837>.
- Had to hold back matplotlib from 3.9 because it needs a poetry2nix
   override <nix-community/poetry2nix#1659>.
- Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to
   0.1.0.
- Had to add Cython 0 to the color-operations build inputs
   <nix-community/poetry2nix#1658>.

Script:

```bash
cd flooding/sentinel2_water_extraction
poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
cd ../sentinel1_water_extraction/
poetry add --lock gdal="<3.9"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
```
l0b0 added a commit to linz/emergency-management-tools that referenced this pull request May 23, 2024
Challenges:

- Had to hold back GDAL from 3.9 because it's not yet in nixpkgs
   <NixOS/nixpkgs#311310>.
- Had to hold back numexpr from 2.10 because it's not yet in nixpkgs
   <NixOS/nixpkgs#310837>.
- Had to hold back matplotlib from 3.9 because it needs a poetry2nix
   override <nix-community/poetry2nix#1659>.
- Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to
   0.1.0.
- Had to add Cython 0 to the color-operations build inputs
   <nix-community/poetry2nix#1658>.

Script:

```bash
cd flooding/sentinel2_water_extraction
poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
cd ../sentinel1_water_extraction/
poetry add --lock gdal="<3.9"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
```
@imincik imincik mentioned this pull request May 28, 2024
13 tasks
@imincik
Copy link
Contributor Author

imincik commented May 30, 2024

Result of nixpkgs-review pr 311310 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
49 packages failed to build:
  • apacheHttpdPackages.mod_tile
  • cloudcompare
  • entwine
  • grass
  • pdal
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • qgis
  • qgis-ltr
85 packages built:
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresql15JitPackages.postgis
  • postgresql15JitPackages.postgis.doc
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.gdal
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • pytrainer
  • pytrainer.dist
  • qmapshack
  • saga
  • sumo
  • t-rex
  • udig
  • vpv

@imincik imincik mentioned this pull request Jun 3, 2024
@imincik
Copy link
Contributor Author

imincik commented Jun 10, 2024

Result of nixpkgs-review pr 311310 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
47 packages failed to build:
  • apacheHttpdPackages.mod_tile
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
95 packages built:
  • cloudcompare
  • entwine
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • grass
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresql15JitPackages.postgis
  • postgresql15JitPackages.postgis.doc
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.gdal
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • sumo
  • t-rex
  • udig
  • vpv

@imincik
Copy link
Contributor Author

imincik commented Jun 10, 2024

Result of nixpkgs-review pr 311310 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
142 packages built:
  • apacheHttpdPackages.mod_tile
  • cloudcompare
  • entwine
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • grass
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresql15JitPackages.postgis
  • postgresql15JitPackages.postgis.doc
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.gdal
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • sumo
  • t-rex
  • udig
  • vpv

@imincik imincik marked this pull request as ready for review June 10, 2024 16:45
@imincik
Copy link
Contributor Author

imincik commented Jun 10, 2024

@sikmir , this PR is ready for review now and please run nixpkgs-review on Darwin if you can. Thank you.

Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and the comments are fantastic! Actionable comments for temporary workarounds FTW.

@sikmir
Copy link
Member

sikmir commented Jun 10, 2024

@sikmir , this PR is ready for review now and please run nixpkgs-review on Darwin if you can. Thank you.

Build in progress

@imincik
Copy link
Contributor Author

imincik commented Jun 12, 2024

@sikmir , this PR is ready for review now and please run nixpkgs-review on Darwin if you can. Thank you.

Build in progress

From Geospatial Team Matrix

"""
sikmir: nixpkgs-review pr 311310 takes me already 20h5m15s on darwin, I guess it's no hope to get it done) At least 3 fails so far: python3.11-python-mapnik-unstable-2023-02-23, mapnik-unstable-2023-11-28 and octave-8.4.0-geometry-unstable-2021-07-07.
"""

@imincik
Copy link
Contributor Author

imincik commented Jun 12, 2024

Rebased with current master.

@ofborg ofborg bot requested a review from l0b0 June 12, 2024 11:30
@imincik
Copy link
Contributor Author

imincik commented Jun 12, 2024

Result of nixpkgs-review pr 311310 run on x86_64-linux 1

6 packages marked as broken and skipped:
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
  • worldengine-cli
  • worldengine-cli.dist
144 packages built:
  • apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
  • cloudcompare
  • entwine
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • grass
  • haskellPackages.hgdal
  • haskellPackages.hgdal.doc
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresqlJitPackages.postgis (postgresql15JitPackages.postgis)
  • postgresqlJitPackages.postgis.doc (postgresql15JitPackages.postgis.doc)
  • postgresqlPackages.postgis (postgresql15Packages.postgis)
  • postgresqlPackages.postgis.doc (postgresql15Packages.postgis.doc)
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.gdal
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • sumo
  • t-rex
  • udig
  • vpv

Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, thanks!

@h7x4 h7x4 merged commit 52b0100 into NixOS:master Jun 17, 2024
26 checks passed
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jun 20, 2024
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jun 20, 2024
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jun 20, 2024
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants