Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM fix #131

Closed
SirVer opened this issue Jun 12, 2015 · 4 comments
Closed

ARM fix #131

SirVer opened this issue Jun 12, 2015 · 4 comments

Comments

@SirVer
Copy link
Contributor

SirVer commented Jun 12, 2015

I recently compiled nix for my beagleboard black - it went smoothly, but I got two compile errors, both in uio.rs.

The parameter offset to ffi::pread and ffi::pwrite are i32 on my arm. Maybe they should be isize? I am not sure how to express that in rust in a portable manner.

@posborne
Copy link
Member

I think using off_t here is the right thing to do but off_t does not have the right value for ARM in your environment. Reading the libc lib.rs, it would appear that off_t should be an i32: https://github.com/rust-lang/rust/blob/8b7c17db2235a2a3f2c71242b11fc429a8d05a90/src/liblibc/lib.rs#L454

@SirVer
Copy link
Contributor Author

SirVer commented Jun 15, 2015

I am sorry, my original bug description was not super great. I was back at my machine today and conjectured a fix real quick in attached pull request.

@carllerche
Copy link
Contributor

Fixed by d980897

@SirVer
Copy link
Contributor Author

SirVer commented Jun 19, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants