Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several consts should be bitflags #58

Closed
utkarshkukreti opened this issue Feb 2, 2015 · 7 comments
Closed

Several consts should be bitflags #58

utkarshkukreti opened this issue Feb 2, 2015 · 7 comments

Comments

@utkarshkukreti
Copy link
Contributor

Some random examples (there are many more):

@carllerche
Copy link
Contributor

Looks like you are correct :)

@fiveop
Copy link
Contributor

fiveop commented Jan 23, 2016

After #243 only flags in src/sys/socket/consts.rs should remain to be converted.

@kamalmarhubi
Copy link
Member

@fiveop are you working on the remaining flags?

@fiveop
Copy link
Contributor

fiveop commented Feb 1, 2016

I think we can close this now.

@kamalmarhubi
Copy link
Member

@fiveop did you convert the ones in the original issue, or go over all flags? If the former, I think we could keep this open pending an audit to make sure we're using bitflags all over.

@fiveop
Copy link
Contributor

fiveop commented Feb 4, 2016

I am pretty sure that I found all of them, but please do check again.

@kamalmarhubi
Copy link
Member

@fiveop skimmed all the source, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants