Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened with eventfd? #96

Closed
diwic opened this issue Apr 8, 2015 · 4 comments
Closed

What happened with eventfd? #96

diwic opened this issue Apr 8, 2015 · 4 comments

Comments

@diwic
Copy link
Contributor

diwic commented Apr 8, 2015

I used eventfds as a building block (for benchmarks in my fdringbuf crate), and found that it was suddenly gone (to make it compile on the beta, according to a recent commit).

I'm not really sure what the problem is and if it's easy to bring it back, both on the nightly and on the beta...?

@carllerche
Copy link
Contributor

Sorry about that, I was using #[linkage = weak] as a strategy for providing features that were not globally available. This strategy does not work anymore on beta and will not be stabilized anytime in the foreseeable future. I have plans to bring it back, but it will require a bunch of work.

I can either bring it back via a feature flag until I have time to implement the correct strategy, or you could run a fork that has it. Which would you prefer?

@carllerche
Copy link
Contributor

Here, I pushed it back behind a feature flag: 9b0a534

My plan is to move the feature detection to a build script vs. providing each feature via a feature flag.

@carllerche
Copy link
Contributor

Closing for now, feel free to open another issue if this doesn't resolve your problem.

@diwic
Copy link
Contributor Author

diwic commented Apr 10, 2015

Just dropping by to say thanks for the super-quick fix! I can confirm that it works as expected and I can now again run "cargo bench" for my fdringbuf crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants