-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackages.glpk-hs: fix for ghc-8.6 #64895
Conversation
There has been a release to version 0.7 a month ago. Is this still needed? |
There are still deprecation errors. A pending upstream PR jyp/glpk-hs#11 from which I've taken the patch hasn't been merged yet. I'll remove |
c4908e7
to
2408129
Compare
2408129
to
776be33
Compare
# https://github.com/jyp/glpk-hs/pull/11 | ||
# patch is the above PR with conflicts resolved | ||
glpk-hs = assert super.glpk-hs.version == "0.7"; | ||
appendPatch super.glpk-hs ./patches/glpk-hs-ghc86.patch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, in nixpkgs we generally prefer to pull patches from upstream directly with fetchpatch
. There should be some examples of doing this in this file.
Can you rewrite this to use fetchpatch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was exactly my previous approach, but the PR in its current form has merge conflicts with 0.7 and the patching fails. If there is a cleaner solution other than creating a patch manually, I would certainly use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pschuprikov Could you send the patch in this PR as a PR to upstream?
@pschuprikov Can you rebase this on the |
776be33
to
8dc226a
Compare
aa46cdd
to
fdd64fb
Compare
ff24de1
to
8842566
Compare
5011d9e
to
0685be7
Compare
Please submit a cleaned-up version of the change if you're still interested in fixing this issue. |
Motivation for this change
From what I was able to understand, the hackage version of glpk-hs does not work with the new gasp. Moreover, due to deprecated calls glpk-hs doesn't compile with ghc-8.6, which is fixed by the patch.
The last upstream change was 8 months ago.
Things done
Compiles fine with ghc-8.4.4, ghc-8.6.5, ghc-8.8.1.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)