Some fixes in nix-prefetch-git #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking `nix-prefetch-git --url smth --ref smth` (when expected hash is not specified)
|
Applied, thanks! |
7 tasks
Closed
srhb
added a commit
to srhb/nixpkgs
that referenced
this pull request
Feb 21, 2018
finlay
pushed a commit
to dragonfly-science/nixpkgs
that referenced
this pull request
Apr 29, 2018
…undation haskellPackages.foundation: disable tests on darwin
dtzWill
added a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jun 17, 2018
Maybe same problem as on Darwin, unsure. From gdb: > Thread 1 (process 23820): > #0 0x00007ffff7dab684 in __syscall_cp_c () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > #1 0x00007ffff7daac69 in __timedwait_cp () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > #2 0x00007ffff7daad17 in __timedwait () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > #3 0x00007ffff7dacaf4 in pthread_mutex_timedlock () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1 > NixOS#4 0x00007ffff781e409 in _gpgrt_lock_lock () from target:/nix/store/f7qid95jabfr665qc1kbcl6adf48gq7w-libgpg-error-1.28/lib/libgpg-error.so.0 > NixOS#5 0x00007ffff7b035d5 in lock_rng () at ./rndjent.c:212 > NixOS#6 0x00007ffff7b036ab in _gcry_rndjent_poll (add=0x0, origin=RANDOM_ORIGIN_INIT, length=0) at ./rndjent.c:268 > NixOS#7 0x00007ffff7b038cf in _gcry_rndjent_get_version (r_active=0x7fffffffc800) at ./rndjent.c:339 > NixOS#8 0x00007ffff7a44f7f in print_config (fp=0x6026e0, what=0x0) at global.c:391 > NixOS#9 _gcry_get_config (mode=mode@entry=0, what=<optimized out>, what@entry=0x0) at global.c:420 > NixOS#10 0x00007ffff7a456a3 in _gcry_vcontrol (cmd=<optimized out>, arg_ptr=<optimized out>) at global.c:652 > NixOS#11 0x00007ffff7a41689 in gcry_control (cmd=cmd@entry=GCRYCTL_PRINT_CONFIG) at visibility.c:79 > NixOS#12 0x0000000000400ec3 in main (argc=<optimized out>, argv=<optimized out>) at version.c:160
8 tasks
dingxiangfei2009
pushed a commit
to dingxiangfei2009/nixpkgs
that referenced
this pull request
Jan 9, 2019
Add `libnss` and `cacert` to `elm` runtime dependencies
purcell
pushed a commit
to purcell/nixpkgs
that referenced
this pull request
Feb 13, 2020
buildRustCrate: remove superfluous dependency overrides
10 tasks
Closed
ethancedwards8
pushed a commit
to ethancedwards8/nixpkgs
that referenced
this pull request
Apr 2, 2021
Add programs.fish
primeos
added a commit
to primeos/nixpkgs
that referenced
this pull request
May 27, 2021
FAIL: LLVM :: DebugInfo/X86/vla-multi.ll (25780 of 42068) ******************** TEST 'LLVM :: DebugInfo/X86/vla-multi.ll' FAILED ******************** Script: -- : 'RUN: at line 1'; /build/llvm/build/bin/llc -mtriple=x86_64-apple-darwin /build/llvm/test/DebugInfo/X86/vla-multi.ll -o - -filetype=obj | /build/llvm/build/bin/llvm-dwarfdump - | /build/llvm/build/bin/FileCheck --allow-unused-prefixes=false /build/llvm/test/DebugInfo/X86/vla-multi.ll -- Exit Code: 2 Command Output (stderr): -- PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace. Stack dump: 0. Program arguments: /build/llvm/build/bin/llc -mtriple=x86_64-apple-darwin /build/llvm/test/DebugInfo/X86/vla-multi.ll -o - -filetype=obj #0 0x00007ffff286ac1d llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/build/llvm/build/lib/libLLVM-12.so+0xd51c1d) #1 0x00007ffff2868924 llvm::sys::RunSignalHandlers() (/build/llvm/build/lib/libLLVM-12.so+0xd4f924) #2 0x00007ffff2868a9b SignalHandler(int) (/build/llvm/build/lib/libLLVM-12.so+0xd4fa9b) #3 0x00007ffff1b0b700 __restore_rt (/nix/store/sbbifs2ykc05inws26203h0xwcadnf0l-glibc-2.32-46/lib/libpthread.so.0+0x13700) #4 0x00007ffff31c2430 llvm::DIE::getUnitDie() const (/build/llvm/build/lib/libLLVM-12.so+0x16a9430) NixOS#5 0x00007ffff31e0f5c llvm::DwarfDebug::finishEntityDefinitions() (/build/llvm/build/lib/libLLVM-12.so+0x16c7f5c) NixOS#6 0x00007ffff31f9415 llvm::DwarfDebug::finalizeModuleInfo() (/build/llvm/build/lib/libLLVM-12.so+0x16e0415) NixOS#7 0x00007ffff31fc558 llvm::DwarfDebug::endModule() (/build/llvm/build/lib/libLLVM-12.so+0x16e3558) NixOS#8 0x00007ffff31ab659 llvm::AsmPrinter::doFinalization(llvm::Module&) (/build/llvm/build/lib/libLLVM-12.so+0x1692659) NixOS#9 0x00007ffff29ab77d llvm::FPPassManager::doFinalization(llvm::Module&) (.localalias) (/build/llvm/build/lib/libLLVM-12.so+0xe9277d) NixOS#10 0x00007ffff29b7570 llvm::legacy::PassManagerImpl::run(llvm::Module&) (/build/llvm/build/lib/libLLVM-12.so+0xe9e570) NixOS#11 0x0000000000415bbf compileModule(char**, llvm::LLVMContext&) (/build/llvm/build/bin/llc+0x415bbf) NixOS#12 0x000000000040e582 main (/build/llvm/build/bin/llc+0x40e582) NixOS#13 0x00007ffff162aded __libc_start_main (/nix/store/sbbifs2ykc05inws26203h0xwcadnf0l-glibc-2.32-46/lib/libc.so.6+0x27ded) NixOS#14 0x000000000040eb5a _start /build/glibc-2.32/csu/../sysdeps/x86_64/start.S:122:0 error: -: The file was not recognized as a valid object file FileCheck error: '<stdin>' is empty. FileCheck command line: /build/llvm/build/bin/FileCheck --allow-unused-prefixes=false /build/llvm/test/DebugInfo/X86/vla-multi.ll -- ********************
qjcg
added a commit
to qjcg/nixpkgs
that referenced
this pull request
Jul 23, 2021
ci: Use "main" as primary job name
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Apr 22, 2022
The following error occurs when using `imagemagickBig`:
$ ./result/bin/identify sample.jp2
[1] 699089 IOT instruction (core dumped) ./result/bin/identify sample.jp2
When looking at the call-trace it seems as if certain symbols, e.g.
`opj_malloc` are mixed up:
NixOS#8 0x00007f78c79ad2f5 in MagickSignalHandler.cold () from /nix/store/bqy80qiw6czqh7vsmmmivwdswp9zzjgl-imagemagick-7.1.0-29/lib/libMagickCore-7.Q16HDRI.so.10
NixOS#9 <signal handler called>
NixOS#10 0x00007f78c5a6095f in opj_malloc () from /nix/store/wg6ly83k1k1fjiygiv1jr7li3p6dwsvq-ghostscript-with-X-9.55.0/lib/libgs.so.9
NixOS#11 0x00007f78c5a60981 in opj_calloc () from /nix/store/wg6ly83k1k1fjiygiv1jr7li3p6dwsvq-ghostscript-with-X-9.55.0/lib/libgs.so.9
NixOS#12 0x00007f78c4f48e24 in opj_create_decompress () from /nix/store/qwalb0kjz1p9c4j48qkk6ql47ds2lnhh-openjpeg-2.4.0/lib/libopenjp2.so.7
The `opj_create_decompress()` is called from the `openjpeg`-integration
of `imagemagick` and thus shouldn't affect `ghostscript` at all.
However, `ghostscript` (`libgs.so` to be precise) also exposes e.g.
`opj_malloc`:
$ objdump -t /nix/store/wg6ly83k1k1fjiygiv1jr7li3p6dwsvq-ghostscript-with-X-9.55.0/lib/libgs.so.9.55|grep opj_malloc
0000000000205940 g F .text 000000000000002b opj_malloc
Because of that, two incompatible symbols are used in the same process
and thus the `identify`-call breaks because the wrong one is used. To
work around that I decided to use the system-wide openjpeg instead.
I'm not sure why `libgs.so` wants to expose these symbols anyways, but
with that workaround the problem is solved.
Even though it's mentioned that ghostscript's openjpeg is heavily
patched, I think that this is somewhat outdated or at least irrelevant
considering that both ArchLinux[1] and Fedora[2] use the system-wide
`openjpeg` instead.
[1] https://github.com/archlinux/svntogit-packages/blob/bafcb5473b59d5386dd110d1cb249372dce9ea6c/trunk/PKGBUILD#L50
[2] https://src.fedoraproject.org/rpms/ghostscript/blob/e4eec13ab6ace2bad64b740d352964bbf61d1aa7/f/ghostscript.spec#_245
0x4A6F
added a commit
to 0x4A6F/nixpkgs
that referenced
this pull request
May 1, 2023
TODO: riscv64-linux support -> configure: error: Unsupported host architecture. Sorry ``` copying path '/nix/store/0l591mfab7wpi0npvipcvw2hc563a5pz-attachment.cgi?id=148912' from 'https://cache.nixos.org'... copying path '/nix/store/5kj0bygmawclh3sv9qxd6m01bknnpn4h-attachment.cgi?id=149172' from 'https://cache.nixos.org'... copying path '/nix/store/8bi7cd4h9bsi08014pciq4znsz3rm0p3-attachment.cgi?id=149174' from 'https://cache.nixos.org'... copying path '/nix/store/54ymrdbm76hgfcja30403wgvkd64sm8a-attachment.cgi?id=149173' from 'https://cache.nixos.org'... copying path '/nix/store/k09gxfmfpd4x9h1nva8igfbz7zh94xgy-elfv2-ppc64-be.patch' from 'https://cache.nixos.org'... copying path '/nix/store/fq5r10nswpwb709l87jphx6yc8rbq186-valgrind-3.20.0.tar.bz2' from 'https://cache.nixos.org'... unpacking sources unpacking source archive /nix/store/fq5r10nswpwb709l87jphx6yc8rbq186-valgrind-3.20.0.tar.bz2 source root is valgrind-3.20.0 setting SOURCE_DATE_EPOCH to timestamp 1666612870 of file valgrind-3.20.0/docs/vgdb.1 patching sources applying patch /nix/store/k09gxfmfpd4x9h1nva8igfbz7zh94xgy-elfv2-ppc64-be.patch patching file coregrind/m_dispatch/dispatch-ppc64be-linux.S Hunk #1 succeeded at 86 (offset -2 lines). Hunk NixOS#2 succeeded at 255 (offset -1 lines). patching file coregrind/m_initimg/initimg-linux.c Hunk #1 succeeded at 1206 (offset 89 lines). patching file coregrind/m_libcsetjmp.c Hunk #1 succeeded at 33 (offset -2 lines). Hunk NixOS#2 succeeded at 150 (offset -2 lines). Hunk NixOS#3 succeeded at 270 (offset -2 lines). patching file coregrind/m_machine.c Hunk #1 succeeded at 2383 (offset 285 lines). patching file coregrind/m_main.c Hunk #1 succeeded at 2393 (offset 90 lines). Hunk NixOS#2 succeeded at 2426 (offset 90 lines). Hunk NixOS#3 succeeded at 2750 (offset 91 lines). Hunk NixOS#4 succeeded at 2797 (offset 91 lines). patching file coregrind/m_sigframe/sigframe-ppc64-linux.c Hunk #1 succeeded at 261 (offset -2 lines). patching file coregrind/m_signals.c Hunk #1 succeeded at 955 (offset 58 lines). Hunk NixOS#2 succeeded at 972 (offset 58 lines). patching file coregrind/m_stacktrace.c Hunk #1 succeeded at 747 (offset 21 lines). Hunk NixOS#2 succeeded at 809 (offset 21 lines). Hunk NixOS#3 succeeded at 862 (offset 21 lines). Hunk NixOS#4 succeeded at 882 (offset 21 lines). patching file coregrind/m_syscall.c Hunk #1 succeeded at 539 (offset 69 lines). Hunk NixOS#2 succeeded at 576 (offset 69 lines). patching file coregrind/m_syswrap/syscall-ppc64be-linux.S Hunk #1 succeeded at 74 (offset -2 lines). Hunk NixOS#2 succeeded at 156 (offset -2 lines). patching file coregrind/m_syswrap/syswrap-ppc64-linux.c Hunk #1 succeeded at 39 (offset -2 lines). Hunk NixOS#2 succeeded at 75 (offset -2 lines). Hunk NixOS#3 succeeded at 126 (offset -2 lines). Hunk NixOS#4 succeeded at 211 (offset -2 lines). patching file coregrind/m_trampoline.S Hunk #1 succeeded at 467 (offset -2 lines). patching file coregrind/m_translate.c Hunk #1 succeeded at 1016 (offset 10 lines). Hunk NixOS#2 succeeded at 1245 (offset 10 lines). Hunk NixOS#3 succeeded at 1275 (offset 10 lines). Hunk NixOS#4 succeeded at 1298 (offset 10 lines). Hunk NixOS#5 succeeded at 1379 (offset 10 lines). Hunk NixOS#6 succeeded at 1435 (offset 10 lines). Hunk NixOS#7 succeeded at 1658 (offset 10 lines). Hunk NixOS#8 succeeded at 1706 (offset 13 lines). patching file coregrind/m_ume/elf.c Hunk #1 succeeded at 856 (offset 9 lines). Hunk NixOS#2 succeeded at 865 (offset 9 lines). patching file coregrind/pub_core_machine.h Hunk #1 succeeded at 58 (offset -2 lines). patching file coregrind/vg_preloaded.c Hunk #1 succeeded at 43 with fuzz 1 (offset -2 lines). Hunk NixOS#2 succeeded at 105 (offset 1 line). patching file include/valgrind.h Hunk #1 succeeded at 151 (offset 8 lines). patching file memcheck/mc_leakcheck.c Hunk #1 succeeded at 651 (offset -2 lines). patching file memcheck/mc_machine.c Hunk #1 succeeded at 130 (offset -2 lines). applying patch /nix/store/0l591mfab7wpi0npvipcvw2hc563a5pz-attachment.cgi?id=148912 patching file memcheck/tests/arm64-linux/scalar.h patching file memcheck/tests/x86-linux/scalar.h applying patch /nix/store/5kj0bygmawclh3sv9qxd6m01bknnpn4h-attachment.cgi?id=149172 patching file none/tests/arm/Makefile.am applying patch /nix/store/54ymrdbm76hgfcja30403wgvkd64sm8a-attachment.cgi?id=149173 patching file memcheck/tests/sh-mem-random.c applying patch /nix/store/8bi7cd4h9bsi08014pciq4znsz3rm0p3-attachment.cgi?id=149174 patching file Makefile.all.am patching file helgrind/tests/Makefile.am patching file none/tests/arm/Makefile.am autoreconfPhase autoreconf: export WARNINGS= autoreconf: Entering directory '.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal --force autoreconf: configure.ac: tracing autoreconf: configure.ac: not using Libtool autoreconf: configure.ac: not using Intltool autoreconf: configure.ac: not using Gtkdoc autoreconf: running: /nix/store/ncj4sssb2nxdk48flyxk43cyfv569248-autoconf-2.71/bin/autoconf --force configure.ac:140: warning: The macro `AC_PROG_CC_C99' is obsolete. configure.ac:140: You should run autoupdate. ./lib/autoconf/c.m4:1659: AC_PROG_CC_C99 is expanded from... configure.ac:140: the top level autoreconf: running: /nix/store/ncj4sssb2nxdk48flyxk43cyfv569248-autoconf-2.71/bin/autoheader --force autoreconf: running: automake --add-missing --copy --force-missing autoreconf: Leaving directory '.' autoreconfPhase completed in 1 minutes 30 seconds updateAutotoolsGnuConfigScriptsPhase Updating Autotools / GNU config script to a newer upstream version: ./config.sub Updating Autotools / GNU config script to a newer upstream version: ./config.guess configuring configure flags: --disable-dependency-tracking --prefix=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0 --bindir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/bin --sbindir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/sbin --includedir=/nix/store/zlwg789mqc2hp1zy1hh3whlp612msm5w-valgrind-3.20.0-dev/include --oldincludedir=/nix/store/zlwg789mqc2hp1zy1hh3whlp612msm5w-valgrind-3.20.0-dev/include --mandir=/nix/store/9awl3c5hyng7prsapggkrlz5phs45zjb-valgrind-3.20.0-man/share/man --infodir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/share/info --docdir=/nix/store/4hh37s3zxm0vi3j45pkzpgh5qbcwqfff-valgrind-3.20.0-doc/share/doc/valgrind --libdir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/lib --libexecdir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/libexec --localedir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/share/locale checking for a BSD-compatible install... /nix/store/jddgwf186d0sqajjv4iibnnpc6dfxj7x-coreutils-9.1/bin/install -c checking whether build environment is sane... yes checking for a race-free mkdir -p... /nix/store/jddgwf186d0sqajjv4iibnnpc6dfxj7x-coreutils-9.1/bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether to enable maintainer-specific portions of Makefiles... no checking whether ln -s works... yes checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether the compiler supports GNU C... yes checking whether gcc accepts -g... yes checking for gcc option to enable C11 features... none needed checking whether gcc understands -c and -o together... yes checking whether make supports the include directive... yes (GNU style) checking dependency style of gcc... none checking how to run the C preprocessor... gcc -E checking whether the compiler supports GNU C++... yes checking whether g++ accepts -g... yes checking for g++ option to enable C++11 features... none needed checking dependency style of g++... none checking for ranlib... ranlib checking for gcc-ranlib... /nix/store/fpvd6m6822fgc9rjq8hbs67dh154pr0c-gcc-12.2.0/bin/gcc-ranlib checking for a sed that does not truncate output... /nix/store/6lac07v5y4mwbca83sgfgn6hvkn4blz7-gnused-4.9/bin/sed checking for gcc-ar... /nix/store/fpvd6m6822fgc9rjq8hbs67dh154pr0c-gcc-12.2.0/bin/gcc-ar checking for perl... /nix/store/fgkv333lywsz5x7pr6dx2n3mm8gc7s0c-perl-5.36.0/bin/perl checking for gdb... /nix/store/4xpnrwacahz4m6s56h4k88sdwajj2zis-gdb-13.1/bin/gdb checking dependency style of gcc... none checking for diff -u... yes checking for a supported version of gcc... ok (12.2.0) checking build system type... riscv64-unknown-linux-gnu checking host system type... riscv64-unknown-linux-gnu checking for a supported CPU... no (riscv64) configure: error: Unsupported host architecture. Sorry ```
0x4A6F
added a commit
to 0x4A6F/nixpkgs
that referenced
this pull request
May 1, 2023
TODO: riscv64-linux support -> configure: error: Unsupported host architecture. Sorry ``` copying path '/nix/store/0l591mfab7wpi0npvipcvw2hc563a5pz-attachment.cgi?id=148912' from 'https://cache.nixos.org'... copying path '/nix/store/5kj0bygmawclh3sv9qxd6m01bknnpn4h-attachment.cgi?id=149172' from 'https://cache.nixos.org'... copying path '/nix/store/8bi7cd4h9bsi08014pciq4znsz3rm0p3-attachment.cgi?id=149174' from 'https://cache.nixos.org'... copying path '/nix/store/54ymrdbm76hgfcja30403wgvkd64sm8a-attachment.cgi?id=149173' from 'https://cache.nixos.org'... copying path '/nix/store/k09gxfmfpd4x9h1nva8igfbz7zh94xgy-elfv2-ppc64-be.patch' from 'https://cache.nixos.org'... copying path '/nix/store/fq5r10nswpwb709l87jphx6yc8rbq186-valgrind-3.20.0.tar.bz2' from 'https://cache.nixos.org'... unpacking sources unpacking source archive /nix/store/fq5r10nswpwb709l87jphx6yc8rbq186-valgrind-3.20.0.tar.bz2 source root is valgrind-3.20.0 setting SOURCE_DATE_EPOCH to timestamp 1666612870 of file valgrind-3.20.0/docs/vgdb.1 patching sources applying patch /nix/store/k09gxfmfpd4x9h1nva8igfbz7zh94xgy-elfv2-ppc64-be.patch patching file coregrind/m_dispatch/dispatch-ppc64be-linux.S Hunk #1 succeeded at 86 (offset -2 lines). Hunk NixOS#2 succeeded at 255 (offset -1 lines). patching file coregrind/m_initimg/initimg-linux.c Hunk #1 succeeded at 1206 (offset 89 lines). patching file coregrind/m_libcsetjmp.c Hunk #1 succeeded at 33 (offset -2 lines). Hunk NixOS#2 succeeded at 150 (offset -2 lines). Hunk NixOS#3 succeeded at 270 (offset -2 lines). patching file coregrind/m_machine.c Hunk #1 succeeded at 2383 (offset 285 lines). patching file coregrind/m_main.c Hunk #1 succeeded at 2393 (offset 90 lines). Hunk NixOS#2 succeeded at 2426 (offset 90 lines). Hunk NixOS#3 succeeded at 2750 (offset 91 lines). Hunk NixOS#4 succeeded at 2797 (offset 91 lines). patching file coregrind/m_sigframe/sigframe-ppc64-linux.c Hunk #1 succeeded at 261 (offset -2 lines). patching file coregrind/m_signals.c Hunk #1 succeeded at 955 (offset 58 lines). Hunk NixOS#2 succeeded at 972 (offset 58 lines). patching file coregrind/m_stacktrace.c Hunk #1 succeeded at 747 (offset 21 lines). Hunk NixOS#2 succeeded at 809 (offset 21 lines). Hunk NixOS#3 succeeded at 862 (offset 21 lines). Hunk NixOS#4 succeeded at 882 (offset 21 lines). patching file coregrind/m_syscall.c Hunk #1 succeeded at 539 (offset 69 lines). Hunk NixOS#2 succeeded at 576 (offset 69 lines). patching file coregrind/m_syswrap/syscall-ppc64be-linux.S Hunk #1 succeeded at 74 (offset -2 lines). Hunk NixOS#2 succeeded at 156 (offset -2 lines). patching file coregrind/m_syswrap/syswrap-ppc64-linux.c Hunk #1 succeeded at 39 (offset -2 lines). Hunk NixOS#2 succeeded at 75 (offset -2 lines). Hunk NixOS#3 succeeded at 126 (offset -2 lines). Hunk NixOS#4 succeeded at 211 (offset -2 lines). patching file coregrind/m_trampoline.S Hunk #1 succeeded at 467 (offset -2 lines). patching file coregrind/m_translate.c Hunk #1 succeeded at 1016 (offset 10 lines). Hunk NixOS#2 succeeded at 1245 (offset 10 lines). Hunk NixOS#3 succeeded at 1275 (offset 10 lines). Hunk NixOS#4 succeeded at 1298 (offset 10 lines). Hunk NixOS#5 succeeded at 1379 (offset 10 lines). Hunk NixOS#6 succeeded at 1435 (offset 10 lines). Hunk NixOS#7 succeeded at 1658 (offset 10 lines). Hunk NixOS#8 succeeded at 1706 (offset 13 lines). patching file coregrind/m_ume/elf.c Hunk #1 succeeded at 856 (offset 9 lines). Hunk NixOS#2 succeeded at 865 (offset 9 lines). patching file coregrind/pub_core_machine.h Hunk #1 succeeded at 58 (offset -2 lines). patching file coregrind/vg_preloaded.c Hunk #1 succeeded at 43 with fuzz 1 (offset -2 lines). Hunk NixOS#2 succeeded at 105 (offset 1 line). patching file include/valgrind.h Hunk #1 succeeded at 151 (offset 8 lines). patching file memcheck/mc_leakcheck.c Hunk #1 succeeded at 651 (offset -2 lines). patching file memcheck/mc_machine.c Hunk #1 succeeded at 130 (offset -2 lines). applying patch /nix/store/0l591mfab7wpi0npvipcvw2hc563a5pz-attachment.cgi?id=148912 patching file memcheck/tests/arm64-linux/scalar.h patching file memcheck/tests/x86-linux/scalar.h applying patch /nix/store/5kj0bygmawclh3sv9qxd6m01bknnpn4h-attachment.cgi?id=149172 patching file none/tests/arm/Makefile.am applying patch /nix/store/54ymrdbm76hgfcja30403wgvkd64sm8a-attachment.cgi?id=149173 patching file memcheck/tests/sh-mem-random.c applying patch /nix/store/8bi7cd4h9bsi08014pciq4znsz3rm0p3-attachment.cgi?id=149174 patching file Makefile.all.am patching file helgrind/tests/Makefile.am patching file none/tests/arm/Makefile.am autoreconfPhase autoreconf: export WARNINGS= autoreconf: Entering directory '.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal --force autoreconf: configure.ac: tracing autoreconf: configure.ac: not using Libtool autoreconf: configure.ac: not using Intltool autoreconf: configure.ac: not using Gtkdoc autoreconf: running: /nix/store/ncj4sssb2nxdk48flyxk43cyfv569248-autoconf-2.71/bin/autoconf --force configure.ac:140: warning: The macro `AC_PROG_CC_C99' is obsolete. configure.ac:140: You should run autoupdate. ./lib/autoconf/c.m4:1659: AC_PROG_CC_C99 is expanded from... configure.ac:140: the top level autoreconf: running: /nix/store/ncj4sssb2nxdk48flyxk43cyfv569248-autoconf-2.71/bin/autoheader --force autoreconf: running: automake --add-missing --copy --force-missing autoreconf: Leaving directory '.' autoreconfPhase completed in 1 minutes 30 seconds updateAutotoolsGnuConfigScriptsPhase Updating Autotools / GNU config script to a newer upstream version: ./config.sub Updating Autotools / GNU config script to a newer upstream version: ./config.guess configuring configure flags: --disable-dependency-tracking --prefix=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0 --bindir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/bin --sbindir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/sbin --includedir=/nix/store/zlwg789mqc2hp1zy1hh3whlp612msm5w-valgrind-3.20.0-dev/include --oldincludedir=/nix/store/zlwg789mqc2hp1zy1hh3whlp612msm5w-valgrind-3.20.0-dev/include --mandir=/nix/store/9awl3c5hyng7prsapggkrlz5phs45zjb-valgrind-3.20.0-man/share/man --infodir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/share/info --docdir=/nix/store/4hh37s3zxm0vi3j45pkzpgh5qbcwqfff-valgrind-3.20.0-doc/share/doc/valgrind --libdir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/lib --libexecdir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/libexec --localedir=/nix/store/fphvjd8jmb4mxbdzl0idyif64bl60mip-valgrind-3.20.0/share/locale checking for a BSD-compatible install... /nix/store/jddgwf186d0sqajjv4iibnnpc6dfxj7x-coreutils-9.1/bin/install -c checking whether build environment is sane... yes checking for a race-free mkdir -p... /nix/store/jddgwf186d0sqajjv4iibnnpc6dfxj7x-coreutils-9.1/bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether to enable maintainer-specific portions of Makefiles... no checking whether ln -s works... yes checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether the compiler supports GNU C... yes checking whether gcc accepts -g... yes checking for gcc option to enable C11 features... none needed checking whether gcc understands -c and -o together... yes checking whether make supports the include directive... yes (GNU style) checking dependency style of gcc... none checking how to run the C preprocessor... gcc -E checking whether the compiler supports GNU C++... yes checking whether g++ accepts -g... yes checking for g++ option to enable C++11 features... none needed checking dependency style of g++... none checking for ranlib... ranlib checking for gcc-ranlib... /nix/store/fpvd6m6822fgc9rjq8hbs67dh154pr0c-gcc-12.2.0/bin/gcc-ranlib checking for a sed that does not truncate output... /nix/store/6lac07v5y4mwbca83sgfgn6hvkn4blz7-gnused-4.9/bin/sed checking for gcc-ar... /nix/store/fpvd6m6822fgc9rjq8hbs67dh154pr0c-gcc-12.2.0/bin/gcc-ar checking for perl... /nix/store/fgkv333lywsz5x7pr6dx2n3mm8gc7s0c-perl-5.36.0/bin/perl checking for gdb... /nix/store/4xpnrwacahz4m6s56h4k88sdwajj2zis-gdb-13.1/bin/gdb checking dependency style of gcc... none checking for diff -u... yes checking for a supported version of gcc... ok (12.2.0) checking build system type... riscv64-unknown-linux-gnu checking host system type... riscv64-unknown-linux-gnu checking for a supported CPU... no (riscv64) configure: error: Unsupported host architecture. Sorry ```
nat-418
added a commit
to nat-418/nixpkgs
that referenced
this pull request
Jul 8, 2023
Added support for v:count for C-a/C-x
12 tasks
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Aug 4, 2023
Without the change on current `master` `rtorrent` crashes at start as:
*** buffer overflow detected ***: terminated
__pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
44 pthread_kill.c: No such file or directory.
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
NixOS#1 0x00007ffff7880af3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
NixOS#2 0x00007ffff7831c86 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
NixOS#3 0x00007ffff781b8ba in __GI_abort () at abort.c:79
NixOS#4 0x00007ffff781c5f5 in __libc_message (fmt=fmt@entry=0x7ffff7992540 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
NixOS#5 0x00007ffff7910679 in __GI___fortify_fail (msg=msg@entry=0x7ffff79924e6 "buffer overflow detected") at fortify_fail.c:24
NixOS#6 0x00007ffff790eea4 in __GI___chk_fail () at chk_fail.c:28
NixOS#7 0x00007ffff790ea85 in ___snprintf_chk (s=<optimized out>, maxlen=<optimized out>, flag=<optimized out>, slen=<optimized out>, format=<optimized out>) at snprintf_chk.c:29
NixOS#8 0x0000000000472acf in utils::Lockfile::try_lock() ()
NixOS#9 0x000000000044b524 in core::DownloadStore::enable(bool) ()
NixOS#10 0x00000000004b1f7b in Control::initialize() ()
NixOS#11 0x000000000043000b in main ()
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Aug 4, 2023
Pull in _FORTIFY_SOURCE=3 stack smashing fix. Without the change on
current `master` `rtorrent` crashes at start as:
*** buffer overflow detected ***: terminated
__pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
44 pthread_kill.c: No such file or directory.
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
NixOS#1 0x00007ffff7880af3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
NixOS#2 0x00007ffff7831c86 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
NixOS#3 0x00007ffff781b8ba in __GI_abort () at abort.c:79
NixOS#4 0x00007ffff781c5f5 in __libc_message (fmt=fmt@entry=0x7ffff7992540 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
NixOS#5 0x00007ffff7910679 in __GI___fortify_fail (msg=msg@entry=0x7ffff79924e6 "buffer overflow detected") at fortify_fail.c:24
NixOS#6 0x00007ffff790eea4 in __GI___chk_fail () at chk_fail.c:28
NixOS#7 0x00007ffff790ea85 in ___snprintf_chk (s=<optimized out>, maxlen=<optimized out>, flag=<optimized out>, slen=<optimized out>, format=<optimized out>) at snprintf_chk.c:29
NixOS#8 0x0000000000472acf in utils::Lockfile::try_lock() ()
NixOS#9 0x000000000044b524 in core::DownloadStore::enable(bool) ()
NixOS#10 0x00000000004b1f7b in Control::initialize() ()
NixOS#11 0x000000000043000b in main ()
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Sep 13, 2023
Without the change on current `master` `rtorrent` crashes at start as:
*** buffer overflow detected ***: terminated
__pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
44 pthread_kill.c: No such file or directory.
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
NixOS#1 0x00007ffff7880af3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
NixOS#2 0x00007ffff7831c86 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
NixOS#3 0x00007ffff781b8ba in __GI_abort () at abort.c:79
NixOS#4 0x00007ffff781c5f5 in __libc_message (fmt=fmt@entry=0x7ffff7992540 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
NixOS#5 0x00007ffff7910679 in __GI___fortify_fail (msg=msg@entry=0x7ffff79924e6 "buffer overflow detected") at fortify_fail.c:24
NixOS#6 0x00007ffff790eea4 in __GI___chk_fail () at chk_fail.c:28
NixOS#7 0x00007ffff790ea85 in ___snprintf_chk (s=<optimized out>, maxlen=<optimized out>, flag=<optimized out>, slen=<optimized out>, format=<optimized out>) at snprintf_chk.c:29
NixOS#8 0x0000000000472acf in utils::Lockfile::try_lock() ()
NixOS#9 0x000000000044b524 in core::DownloadStore::enable(bool) ()
NixOS#10 0x00000000004b1f7b in Control::initialize() ()
NixOS#11 0x000000000043000b in main ()
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Feb 28, 2024
Without the change `unnethack` startup crashes as:
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
NixOS#1 0x00007f734250c0e3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
NixOS#2 0x00007f73424bce06 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
NixOS#3 0x00007f73424a58f5 in __GI_abort () at abort.c:79
NixOS#4 0x00007f73424a67a1 in __libc_message (fmt=fmt@entry=0x7f734261e2f8 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
NixOS#5 0x00007f734259b1d9 in __GI___fortify_fail (msg=msg@entry=0x7f734261e2df "buffer overflow detected") at fortify_fail.c:24
NixOS#6 0x00007f734259ab94 in __GI___chk_fail () at chk_fail.c:28
NixOS#7 0x00000000005b2ac5 in strcpy (__src=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)",
__dest=0x7ffe68838990 "\001") at /nix/store/B0S2LKF593R3585038WS4JD3LYLF2WDX-glibc-2.38-44-dev/include/bits/string_fortified.h:79
NixOS#8 curses_break_str (str=str@entry=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)", width=width@entry=163,
line_num=line_num@entry=1) at ../win/curses/cursmisc.c:275
NixOS#9 0x00000000005b3f51 in curses_character_input_dialog (prompt=prompt@entry=0x7ffe68838cf0 "Shall I pick a character's race, role, gender and alignment for you?",
choices=choices@entry=0x7ffe68838d70 "YNTQ", def=def@entry=121) at ../win/curses/cursdial.c:211
NixOS#10 0x00000000005b9ca0 in curses_choose_character () at ../win/curses/cursinit.c:556
NixOS#11 0x0000000000404eb1 in main (argc=<optimized out>, argv=<optimized out>) at ./../sys/unix/unixmain.c:309
which corresponds to `gcc` warning:
../win/curses/cursmisc.c: In function 'curses_break_str':
../win/curses/cursmisc.c:275:5: warning: '__builtin___strcpy_chk' writing one too many bytes into a region of a size that depends on 'strlen' [-Wstringop-overflow=]
275 | strcpy(substr, str);
| ^
I did not find a single small upstream change that fixes it. Let's
disable `fortify3` until next release.
Closes: NixOS#292113
Sanskarzz
pushed a commit
to Sanskarzz/nixpkgs
that referenced
this pull request
Feb 29, 2024
Without the change `unnethack` startup crashes as:
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
NixOS#1 0x00007f734250c0e3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
NixOS#2 0x00007f73424bce06 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
NixOS#3 0x00007f73424a58f5 in __GI_abort () at abort.c:79
NixOS#4 0x00007f73424a67a1 in __libc_message (fmt=fmt@entry=0x7f734261e2f8 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
NixOS#5 0x00007f734259b1d9 in __GI___fortify_fail (msg=msg@entry=0x7f734261e2df "buffer overflow detected") at fortify_fail.c:24
NixOS#6 0x00007f734259ab94 in __GI___chk_fail () at chk_fail.c:28
NixOS#7 0x00000000005b2ac5 in strcpy (__src=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)",
__dest=0x7ffe68838990 "\001") at /nix/store/B0S2LKF593R3585038WS4JD3LYLF2WDX-glibc-2.38-44-dev/include/bits/string_fortified.h:79
NixOS#8 curses_break_str (str=str@entry=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)", width=width@entry=163,
line_num=line_num@entry=1) at ../win/curses/cursmisc.c:275
NixOS#9 0x00000000005b3f51 in curses_character_input_dialog (prompt=prompt@entry=0x7ffe68838cf0 "Shall I pick a character's race, role, gender and alignment for you?",
choices=choices@entry=0x7ffe68838d70 "YNTQ", def=def@entry=121) at ../win/curses/cursdial.c:211
NixOS#10 0x00000000005b9ca0 in curses_choose_character () at ../win/curses/cursinit.c:556
NixOS#11 0x0000000000404eb1 in main (argc=<optimized out>, argv=<optimized out>) at ./../sys/unix/unixmain.c:309
which corresponds to `gcc` warning:
../win/curses/cursmisc.c: In function 'curses_break_str':
../win/curses/cursmisc.c:275:5: warning: '__builtin___strcpy_chk' writing one too many bytes into a region of a size that depends on 'strlen' [-Wstringop-overflow=]
275 | strcpy(substr, str);
| ^
I did not find a single small upstream change that fixes it. Let's
disable `fortify3` until next release.
Closes: NixOS#292113
ReedClanton
pushed a commit
to ReedClanton/nixpkgs
that referenced
this pull request
Mar 4, 2024
Without the change `unnethack` startup crashes as:
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
NixOS#1 0x00007f734250c0e3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
NixOS#2 0x00007f73424bce06 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
NixOS#3 0x00007f73424a58f5 in __GI_abort () at abort.c:79
NixOS#4 0x00007f73424a67a1 in __libc_message (fmt=fmt@entry=0x7f734261e2f8 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
NixOS#5 0x00007f734259b1d9 in __GI___fortify_fail (msg=msg@entry=0x7f734261e2df "buffer overflow detected") at fortify_fail.c:24
NixOS#6 0x00007f734259ab94 in __GI___chk_fail () at chk_fail.c:28
NixOS#7 0x00000000005b2ac5 in strcpy (__src=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)",
__dest=0x7ffe68838990 "\001") at /nix/store/B0S2LKF593R3585038WS4JD3LYLF2WDX-glibc-2.38-44-dev/include/bits/string_fortified.h:79
NixOS#8 curses_break_str (str=str@entry=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)", width=width@entry=163,
line_num=line_num@entry=1) at ../win/curses/cursmisc.c:275
NixOS#9 0x00000000005b3f51 in curses_character_input_dialog (prompt=prompt@entry=0x7ffe68838cf0 "Shall I pick a character's race, role, gender and alignment for you?",
choices=choices@entry=0x7ffe68838d70 "YNTQ", def=def@entry=121) at ../win/curses/cursdial.c:211
NixOS#10 0x00000000005b9ca0 in curses_choose_character () at ../win/curses/cursinit.c:556
NixOS#11 0x0000000000404eb1 in main (argc=<optimized out>, argv=<optimized out>) at ./../sys/unix/unixmain.c:309
which corresponds to `gcc` warning:
../win/curses/cursmisc.c: In function 'curses_break_str':
../win/curses/cursmisc.c:275:5: warning: '__builtin___strcpy_chk' writing one too many bytes into a region of a size that depends on 'strlen' [-Wstringop-overflow=]
275 | strcpy(substr, str);
| ^
I did not find a single small upstream change that fixes it. Let's
disable `fortify3` until next release.
Closes: NixOS#292113
msfjarvis
pushed a commit
to msfjarvis/nixpkgs
that referenced
this pull request
May 4, 2024
j-openmesh
added a commit
to Openmesh-Network/Xnodepkgs
that referenced
this pull request
Jul 7, 2024
…-config-dynamically Initial netboot configuration for dynamic agent module import
13 tasks
eclairevoyant
added a commit
to eclairevoyant/nixpkgs
that referenced
this pull request
Jul 29, 2024
This adds some extremely helpful and popular encoders in by default: * openjpeg * celt * libwebp * libaom On the `master` branch, closure size for ffmpeg-headless went up 18.5 MiB. ``` $ nix store diff-closures nixpkgs#ffmpeg-headless^bin .#ffmpeg-headless^bin celt: ∅ → 0.11.3, +168.4 KiB ffmpeg-headless: +70.0 KiB giflib: ∅ → 5.2.2, +398.7 KiB lcms2: ∅ → 2.16, +466.2 KiB lerc: ∅ → 4.0.0, +840.2 KiB libaom: ∅ → 3.9.0, +8047.8 KiB libdeflate: ∅ → 1.20, +427.0 KiB libtiff: ∅ → 4.6.0, +655.9 KiB libvmaf: ∅ → 3.0.0, +2665.0 KiB libwebp: ∅ → 1.4.0, +2559.7 KiB openjpeg: ∅ → 2.5.2, +1525.1 KiB zstd: ∅ → 1.5.6, +1158.0 KiB $ nvd diff $(nix build nixpkgs#ffmpeg-headless^bin --print-out-paths --no-link) $(nix build .#ffmpeg-headless^bin --print-out-paths --no-link) <<< /nix/store/4n60lnj3zkjpasd4c56bzhpx2m8lc1sx-ffmpeg-headless-6.1.1-bin >>> /nix/store/884f487w5hac6rs94jq6hq5zqkxdv666-ffmpeg-headless-6.1.1-bin Added packages: [A.] NixOS#1 celt 0.11.3 [A.] NixOS#2 giflib 5.2.2 [A.] NixOS#3 lcms2 2.16 [A.] NixOS#4 lerc 4.0.0 [A.] NixOS#5 libaom 3.9.0 [A.] NixOS#6 libdeflate 1.20 [A.] NixOS#7 libtiff 4.6.0 [A.] NixOS#8 libvmaf 3.0.0 [A.] NixOS#9 libwebp 1.4.0 x2 [A.] NixOS#10 openjpeg 2.5.2 [A.] NixOS#11 zstd 1.5.6 Closure size: 66 -> 78 (15 paths added, 3 paths removed, delta +12, disk usage +18.5MiB). ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this thread.