Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

"Feburary" is misspelled. #28

Closed
sbennett08 opened this issue Feb 19, 2021 · 2 comments
Closed

"Feburary" is misspelled. #28

sbennett08 opened this issue Feb 19, 2021 · 2 comments

Comments

@sbennett08
Copy link

Should be an easy fix here for you :)

We've noticed that the month "February" is misspelled as "Feburary".
We are using a Windows 10 OS and a Chrome browser (version 88).

I'm pretty sure this month is generated by your code when the calendar is printed out? If not, let me know and I'll take another look at the code on our end.

Great calendar widget by the way. It's just what we needed :)

Capture

@nizarmah
Copy link
Owner

nizarmah commented Feb 20, 2021

@sbennett08 😂 thanks for catching it! I have a lot of changes to address, but I'll be sure to address this one first 😃

Great calendar widget by the way. It's just what we needed :)

Thank you! ❤️ This means a lot!

@nizarmah
Copy link
Owner

@sbennett08 alright, so I looked into the issue more closely, and here's what I found out:

Problem

The JavaScript has no problems:

var months = ["January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"];

As you can see, the month is mentioned properly, February.

However, the problem seems to be the README.

months: [ "January", "Feburary", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December" ],

months: [ "January", "Feburary", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December" ],

Solution

So there's two ways to solve the issue.

You can either remove the declared months attribute, which you don't need unless you're making changing to how the months are displayed.

Or you can update the settings from Feburary to February 👍🏼


I also opened a pull request in order to resolve the issue which you can find below. #29


I'm closing this issue 😃

Thank you a lot for raising it, and I'm glad that the widget is being used ❤️

Have a wonderful day 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants