Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify signing method and digest method algorithm #28

Closed
Weasy666 opened this issue Nov 2, 2022 · 3 comments
Closed

Specify signing method and digest method algorithm #28

Weasy666 opened this issue Nov 2, 2022 · 3 comments

Comments

@Weasy666
Copy link
Contributor

Weasy666 commented Nov 2, 2022

Hello!
If taken a look at the code, but couldn't find a way to specify the algorithms used for signing method and digest method. It seems like it is hardcoded to:

  • signing method: http://www.w3.org/2001/04/xmldsig-more#rsa-sha256
  • digest method: http://www.w3.org/2000/09/xmldsig#sha1

for a special german SAML IdP i would need:

  • signing method: http://www.w3.org/2007/05/xmldsig-more#sha256-rsa-MGF1
  • digest method: http://www.w3.org/2001/04/xmlenc#sha256

The IdP does not accept any other algorithm.

Would it be as easy as just replacing the hardcoded strings, or would i need to change something within the crypto module?

@njaremko
Copy link
Owner

njaremko commented Nov 2, 2022

crypto module would need to be updated to support those methods, for example: https://github.com/njaremko/samael/blob/master/src/crypto.rs#L682

@Weasy666
Copy link
Contributor Author

Weasy666 commented Nov 2, 2022

@njaremko
Copy link
Owner

Sorry, life's been hectic, getting back to this, the stuff you're referencing is just templates, you can manually set all those fields on those structs dynamically, have you tried that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants