Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

bind db.connection as well #93

Closed
wants to merge 1 commit into from
Closed

bind db.connection as well #93

wants to merge 1 commit into from

Conversation

challet
Copy link
Contributor

@challet challet commented Dec 21, 2017

Original Laravel DatabaseServiceProvider binds the 'db.connection' service which is missing here.

 dd(app('db.connection'));
Illuminate\Database\PostgresConnection

What I don't understand is it seems to have work previously : https://github.com/njbarrett/laravel-postgis/issues/62

@coveralls
Copy link

coveralls commented Dec 21, 2017

Coverage Status

Coverage remained the same at 84.0% when pulling 1267f2e on challet:patch-1 into b751206 on njbarrett:master.

@challet
Copy link
Contributor Author

challet commented Dec 21, 2017

By the way, it seems that with Larvel 5.5 and package auto-discovery, Phaza\LaravelPostgis\DatabaseServiceProvider is called before the ones from app config and then the service db.factory is not Phaza\LaravelPostgis\Connectors\ConnectionFactory but :

string(5) "phaza"
string(7) "laravel"
Psy Shell v0.8.16 (PHP 7.1.4-1+deb.sury.org~xenial+1 — cli) by Justin Hileman
>>> app('db.factory')
=> Illuminate\Database\Connectors\ConnectionFactory {#215}

@mstaack mstaack closed this Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants