Sweep: Hide the "Mode" button on the top toolbar.

[NJLaPrell]

Details

Update the style so the button is hidden from view.

The file to change is: top-bar.component.html

Checklist

• src/app/top-bar/top-bar.component.html ✅ Commit a243483

• Find the HTML code for the "Mode" button. It should be a button element with the text "Mode". • Add the "*ngIf" directive to the button element and bind it to a flag (e.g., "showModeButton") in the component's TypeScript file. The code should look like this: Mode

• src/app/top-bar/top-bar.component.ts ✅ Commit 88f205a

• Add a new property "showModeButton" to the component class and set its value to false. This will hide the "Mode" button.

[sweep-self-hosted-njlaprell]

Here's the PR! #48.

💎 Sweep Pro: I used GPT-4 to create this ticket. You have unlimited GPT-4 tickets. To retrigger Sweep, edit the issue.

---

Step 1: 📍 Planning

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

gek/src/app/top-bar/top-bar.component.html

Lines 1 to 57 in 3d45ac5

	<div id="top-bar-contents" class="p-2" [class.viewer]="mode === 'viewer'">
	<div id="app-title" [class.viewer]="mode === 'viewer'" (click)="home()">
	<!--
	<svg viewBox="-4 -4 100 28" preserveAspectRatio="xMidYMid meet" focusable="false" class="logo" style="width: 100px; pointer-events: none; display: inline-block;"><g viewBox="0 0 90 20" preserveAspectRatio="xMidYMid meet" class="style-scope yt-icon"><g class="style-scope yt-icon"><path d="M27.9727 3.12324C27.6435 1.89323 26.6768 0.926623 25.4468 0.597366C23.2197 2.24288e-07 14.285 0 14.285 0C14.285 0 5.35042 2.24288e-07 3.12323 0.597366C1.89323 0.926623 0.926623 1.89323 0.597366 3.12324C2.24288e-07 5.35042 0 10 0 10C0 10 2.24288e-07 14.6496 0.597366 16.8768C0.926623 18.1068 1.89323 19.0734 3.12323 19.4026C5.35042 20 14.285 20 14.285 20C14.285 20 23.2197 20 25.4468 19.4026C26.6768 19.0734 27.6435 18.1068 27.9727 16.8768C28.5701 14.6496 28.5701 10 28.5701 10C28.5701 10 28.5677 5.35042 27.9727 3.12324Z" fill="#FF0000" class="style-scope yt-icon"></path><path d="M11.4253 14.2854L18.8477 10.0004L11.4253 5.71533V14.2854Z" fill="#FFFFFF" class="style-scope yt-icon"></path></g><g class="style-scope yt-icon"><g id="youtube-paths" class="style-scope yt-icon"><path fill="#FFFFFF" d="M34.6024 13.0036L31.3945 1.41846H34.1932L35.3174 6.6701C35.6043 7.96361 35.8136 9.06662 35.95 9.97913H36.0323C36.1264 9.32532 36.3381 8.22937 36.665 6.68892L37.8291 1.41846H40.6278L37.3799 13.0036V18.561H34.6001V13.0036H34.6024Z" class="style-scope yt-icon"></path><path fill="#FFFFFF" d="M41.4697 18.1937C40.9053 17.8127 40.5031 17.22 40.2632 16.4157C40.0257 15.6114 39.9058 14.5437 39.9058 13.2078V11.3898C39.9058 10.0422 40.0422 8.95805 40.315 8.14196C40.5878 7.32588 41.0135 6.72851 41.592 6.35457C42.1706 5.98063 42.9302 5.79248 43.871 5.79248C44.7976 5.79248 45.5384 5.98298 46.0981 6.36398C46.6555 6.74497 47.0647 7.34234 47.3234 8.15137C47.5821 8.96275 47.7115 10.0422 47.7115 11.3898V13.2078C47.7115 14.5437 47.5845 15.6161 47.3329 16.4251C47.0812 17.2365 46.672 17.8292 46.1075 18.2031C45.5431 18.5771 44.7764 18.7652 43.8098 18.7652C42.8126 18.7675 42.0342 18.5747 41.4697 18.1937ZM44.6353 16.2323C44.7905 15.8231 44.8705 15.1575 44.8705 14.2309V10.3292C44.8705 9.43077 44.7929 8.77225 44.6353 8.35833C44.4777 7.94206 44.2026 7.7351 43.8074 7.7351C43.4265 7.7351 43.156 7.94206 43.0008 8.35833C42.8432 8.77461 42.7656 9.43077 42.7656 10.3292V14.2309C42.7656 15.1575 42.8408 15.8254 42.9914 16.2323C43.1419 16.6415 43.4123 16.8461 43.8074 16.8461C44.2026 16.8461 44.4777 16.6415 44.6353 16.2323Z" class="style-scope yt-icon"></path><path fill="#FFFFFF" d="M56.8154 18.5634H54.6094L54.3648 17.03H54.3037C53.7039 18.1871 52.8055 18.7656 51.6061 18.7656C50.7759 18.7656 50.1621 18.4928 49.767 17.9496C49.3719 17.4039 49.1743 16.5526 49.1743 15.3955V6.03751H51.9942V15.2308C51.9942 15.7906 52.0553 16.188 52.1776 16.4256C52.2999 16.6631 52.5045 16.783 52.7914 16.783C53.036 16.783 53.2712 16.7078 53.497 16.5573C53.7228 16.4067 53.8874 16.2162 53.9979 15.9858V6.03516H56.8154V18.5634Z" class="style-scope yt-icon"></path><path fill="#FFFFFF" d="M64.4755 3.68758H61.6768V18.5629H58.9181V3.68758H56.1194V1.42041H64.4755V3.68758Z" class="style-scope yt-icon"></path><path fill="#FFFFFF" d="M71.2768 18.5634H69.0708L68.8262 17.03H68.7651C68.1654 18.1871 67.267 18.7656 66.0675 18.7656C65.2373 18.7656 64.6235 18.4928 64.2284 17.9496C63.8333 17.4039 63.6357 16.5526 63.6357 15.3955V6.03751H66.4556V15.2308C66.4556 15.7906 66.5167 16.188 66.639 16.4256C66.7613 16.6631 66.9659 16.783 67.2529 16.783C67.4974 16.783 67.7326 16.7078 67.9584 16.5573C68.1842 16.4067 68.3488 16.2162 68.4593 15.9858V6.03516H71.2768V18.5634Z" class="style-scope yt-icon"></path><path fill="#FFFFFF" d="M80.609 8.0387C80.4373 7.24849 80.1621 6.67699 79.7812 6.32186C79.4002 5.96674 78.8757 5.79035 78.2078 5.79035C77.6904 5.79035 77.2059 5.93616 76.7567 6.23014C76.3075 6.52412 75.9594 6.90747 75.7148 7.38489H75.6937V0.785645H72.9773V18.5608H75.3056L75.5925 17.3755H75.6537C75.8724 17.7988 76.1993 18.1304 76.6344 18.3774C77.0695 18.622 77.554 18.7443 78.0855 18.7443C79.038 18.7443 79.7412 18.3045 80.1904 17.4272C80.6396 16.5476 80.8653 15.1765 80.8653 13.3092V11.3266C80.8653 9.92722 80.7783 8.82892 80.609 8.0387ZM78.0243 13.1492C78.0243 14.0617 77.9867 14.7767 77.9114 15.2941C77.8362 15.8115 77.7115 16.1808 77.5328 16.3971C77.3564 16.6158 77.1165 16.724 76.8178 16.724C76.585 16.724 76.371 16.6699 76.1734 16.5594C75.9759 16.4512 75.816 16.2866 75.6937 16.0702V8.96062C75.7877 8.6196 75.9524 8.34209 76.1852 8.12337C76.4157 7.90465 76.6697 7.79646 76.9401 7.79646C77.2271 7.79646 77.4481 7.90935 77.6034 8.13278C77.7609 8.35855 77.8691 8.73485 77.9303 9.26636C77.9914 9.79787 78.022 10.5528 78.022 11.5335V13.1492H78.0243Z" class="style-scope yt-icon"></path><path fill="#FFFFFF" d="M84.8657 13.8712C84.8657 14.6755 84.8892 15.2776 84.9363 15.6798C84.9833 16.0819 85.0821 16.3736 85.2326 16.5594C85.3831 16.7428 85.6136 16.8345 85.9264 16.8345C86.3474 16.8345 86.639 16.6699 86.7942 16.343C86.9518 16.0161 87.0365 15.4705 87.0506 14.7085L89.4824 14.8519C89.4965 14.9601 89.5035 15.1106 89.5035 15.3011C89.5035 16.4582 89.186 17.3237 88.5534 17.8952C87.9208 18.4667 87.0247 18.7536 85.8676 18.7536C84.4777 18.7536 83.504 18.3185 82.9466 17.446C82.3869 16.5735 82.1094 15.2259 82.1094 13.4008V11.2136C82.1094 9.33452 82.3987 7.96105 82.9772 7.09558C83.5558 6.2301 84.5459 5.79736 85.9499 5.79736C86.9165 5.79736 87.6597 5.97375 88.1771 6.32888C88.6945 6.684 89.059 7.23433 89.2707 7.98457C89.4824 8.7348 89.5882 9.76961 89.5882 11.0913V13.2362H84.8657V13.8712ZM85.2232 7.96811C85.0797 8.14449 84.9857 8.43377 84.9363 8.83593C84.8892 9.2381 84.8657 9.84722 84.8657 10.6657V11.5641H86.9283V10.6657C86.9283 9.86133 86.9001 9.25221 86.846 8.83593C86.7919 8.41966 86.6931 8.12803 86.5496 7.95635C86.4062 7.78702 86.1851 7.7 85.8864 7.7C85.5854 7.70235 85.3643 7.79172 85.2232 7.96811Z" class="style-scope yt-icon"></path></g></g></g></svg>
	-->
	<img id="app-logo" src="/assets/logo.png" />
	<span id="app-subtitle">Gek</span>
	<span *ngIf="!environment.production" class="ms-2 text-danger">(DEV)</span>
	</div>
	<button *ngIf="mode !=='viewer' && authenticated" class="btn btn-dark btn-sm" (click)="sortVideos()" title="Sort Videos Now">
	<fa-icon [icon]="faRocket"></fa-icon>
	<span class="buttonTitle"> Sort Videos</span>
	</button>
	<button *ngIf="mode !=='viewer' && authenticated" class="btn btn-dark btn-sm" (click)="openRules()" title="Edit Rules">
	<fa-icon [icon]="faClipboardList"></fa-icon>
	<span class="buttonTitle"> Edit Rules</span>
	</button>
	<button *ngIf="mode !=='viewer' && authenticated" class="btn btn-dark btn-sm" (click)="openUnsorted()" title="View Unsorted">
	<fa-icon [icon]="faTableList"></fa-icon>
	<span class="buttonTitle"> Unsorted </span>
	<span *ngIf="unsortedCount" class="badge text-bg-primary">{{ unsortedCount }}</span>
	</button>
	<button *ngIf="mode !== 'player' && authenticated" type="button" class="btn btn-sm btn-dark" (click)="handleModeToggle('player')">
	<fa-icon [icon]="faSquareXmark"></fa-icon> Disconnect
	</button>
	<div *ngIf="mode === 'player' && authenticated" ngbDropdown class="d-inline-block">
	<button type="button" class="btn btn-outline-dark btn-sm text-light" id="mode" ngbDropdownToggle>Mode</button>
	<div ngbDropdownMenu aria-labelledby="mode">
	<button ngbDropdownItem (click)="handleModeToggle('remote')"><fa-icon [icon]="faTabletScreenButton"></fa-icon> Remote</button>
	<button ngbDropdownItem (click)="handleModeToggle('viewer')"><fa-icon [icon]="faTv"></fa-icon> Viewer</button>
	</div>
	</div>
	<div *ngIf="waitingPeerReconnect" class="d-inline-block text-warning pe-2">
	( Waiting for peer to reconnect... <span class="spinner-border" role="status" style="font-size: 0.6em; width: 14px; height: 14px"></span> )
	</div>
	<div *ngIf="authenticated" ngbDropdown class="d-inline-block float-end">
	<button type="button" class="btn btn-outline-dark btn-sm text-light" id="user" ngbDropdownToggle>
	<fa-icon [icon]="faUser"></fa-icon>
	<span class="buttonTitle"> {{ displayName }}</span>
	</button>
	<div ngbDropdownMenu aria-labelledby="user">
	<button ngbDropdownItem (click)="openPreferences()"><fa-icon [icon]="faUserGear"></fa-icon> Preferences</button>
	<button ngbDropdownItem (click)="logout()"><fa-icon [icon]="faRightFromBracket"></fa-icon> Logout</button>
	</div>
	</div>
	<div *ngIf="!authenticated" class="float-end">
	<cool-google-button color="dark" (click)="signin()">
	Sign in with Google
	</cool-google-button>
	</div>

gek/src/app/top-bar/top-bar.component.ts

Lines 1 to 89 in 3d45ac5

	import { Component, EventEmitter, Input, Output } from '@angular/core';
	import {
	faRocket, faRotate, faClipboardList, faTrashCan,
	faTriangleExclamation, faTableList, faUserGear, faSquareXmark, faTv, faTabletScreenButton,
	faRightFromBracket, faUser
	} from '@fortawesome/free-solid-svg-icons';
	import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
	import { UnsortedComponent } from '../modals/unsorted/unsorted.component';
	import { RulesListComponent } from '../modals/rules-list/rules-list.component';
	import { LegalComponent } from '../modals/legal/legal.component';
	import { Store } from '@ngrx/store';
	import { selectHistoryState } from '../state/selectors/history.selectors';
	import { SortProgressComponent } from '../modals/sort-progress/sort-progress.component';
	import { selectRemoteMode, selectPeerConnected, selectConnected } from '../state/selectors/remote.selectors';
	import { disconnect, initializeSocketConnection } from '../state/actions/remote.actions';
	import { Router } from '@angular/router';
	import { PreferencesComponent } from '../modals/preferences/preferences.component';
	import { environment } from '../../environments/environment';
	import { selectDisplayName, selectUserId } from '../state/selectors/auth.selectors';
	import { ToastService } from '../services/toast.service';
	@Component({
	selector: 'app-top-bar',
	templateUrl: './top-bar.component.html',
	styleUrls: ['./top-bar.component.scss']
	})
	export class TopBarComponent {
	// Font Awesome
	faRocket = faRocket;
	faRotate = faRotate;
	faClipboardList = faClipboardList;
	faTrashCan = faTrashCan;
	faTriangleExclamation = faTriangleExclamation;
	faTableList = faTableList;
	faUserGear = faUserGear;
	faSquareXmark = faSquareXmark;
	faTv = faTv;
	faTabletScreenButton = faTabletScreenButton;
	faRightFromBracket = faRightFromBracket;
	faUser = faUser;
	errorCount = 0;
	unsortedCount = 0;
	mode = '';
	waitingPeerReconnect = false;
	private peerConnected = false;
	private selfConnected = false;
	userId: string | false = false;
	environment = environment;
	displayName = '';
	@Input() authenticated = false;
	constructor(
	private modalService: NgbModal,
	private store: Store,
	private router: Router,
	private toast: ToastService
	) {
	this.store.select(selectUserId).subscribe(uid => this.userId = uid);
	this.store.select(selectHistoryState).subscribe(h => {
	this.errorCount = h.errorQueue.length;
	this.unsortedCount = h.unsorted.length;
	});
	this.store.select(selectRemoteMode).subscribe(m => this.mode = m);
	this.store.select(selectPeerConnected).subscribe(c => {
	this.waitingPeerReconnect = this.peerConnected && this.selfConnected && !c;
	this.peerConnected = c;
	});
	this.store.select(selectConnected).subscribe(c => {
	this.waitingPeerReconnect = this.peerConnected && this.selfConnected && !c;
	this.selfConnected = c;
	});
	this.store.select(selectDisplayName).subscribe(n => this.displayName = n);
	}
	openUnsorted() {
	this.modalService.open(UnsortedComponent, { size: 'xl', scrollable: true });
	}
	openRules() {
	this.modalService.open(RulesListComponent, { size: 'xl', scrollable: true });
	}
	openPreferences() {
	this.modalService.open(PreferencesComponent, { size: 'xl', scrollable: true });
	}

---

Step 2: ⌨️ Coding

• src/app/top-bar/top-bar.component.html ✅ Commit a243483

• Find the HTML code for the "Mode" button. It should be a button element with the text "Mode". • Add the "*ngIf" directive to the button element and bind it to a flag (e.g., "showModeButton") in the component's TypeScript file. The code should look like this: Mode

• src/app/top-bar/top-bar.component.ts ✅ Commit 88f205a

• Add a new property "showModeButton" to the component class and set its value to false. This will hide the "Mode" button.

---

Step 3: 🔁 Code Review

Here are my self-reviews of my changes at sweep/hide-mode-button.

Here is the 1st review

Thanks for your contribution. There are a few changes that need to be made:

• In the file src/app/top-bar/top-bar.component.html, TypeScript code has been added which is causing syntax errors as it is not valid HTML. Please remove this TypeScript code from the HTML file. This is found in lines 20-28.

• Also in src/app/top-bar/top-bar.component.html, several elements have been removed from the top bar, not just the "Mode" button as requested in the issue. Please ensure that only the "Mode" button is hidden, and other elements are not affected. This is found in lines 1-19.

• In the file src/app/top-bar/top-bar.component.ts, a new variable showModeButton has been added which could be used to control the visibility of the "Mode" button. However, this variable is not yet used anywhere in the code. Please ensure that this variable is used to hide the "Mode" button as per the issue request. This is found in line 15.

Please make these changes and submit a new pull request. If you need any help, feel free to ask.

I finished incorporating these changes.

---

🎉 Latest improvements to Sweep:

• Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
• Added support for self-hosting! Check out Self-hosting Sweep to get started.
• [Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE

---

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.
^{Join Our Discord}