Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature idea: Ability score analysis of a party #5

Closed
Kudusch opened this issue Sep 24, 2022 · 3 comments
Closed

New feature idea: Ability score analysis of a party #5

Kudusch opened this issue Sep 24, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Kudusch
Copy link
Contributor

Kudusch commented Sep 24, 2022

Love the package and would like to contribute!

I thought it might be a fun feature to input and plot the ability scores of a given list of characters (e.g. a party) to have a better idea of how ability scores are distributed across the characters. This might look something like this:

plot-by-ability
plot-by-player

The main function for this would be something like party_diagram(by = "player"), where the user either gives a list of ability scores or is guided through a simple interactive menu (after the interactive menu was used, the function should also output the representation of the ability score list that can be provided to the function). Here is an example of how this could look:
example-usage

I have a fork with an implementation of this here: Kudusch/dndR@party_diagram
If you feel like this could be in the scope of the package and if you're interested I could to a PR!

@njlyon0 njlyon0 self-assigned this Sep 26, 2022
@njlyon0 njlyon0 added the enhancement New feature or request label Sep 26, 2022
@njlyon0
Copy link
Owner

njlyon0 commented Sep 26, 2022

Wow this looks really cool! Thanks for taking the time to script this out.

Please do submit a PR and I can give it a closer look.

Also, I'd love to add you as an official contributor once we get the PR merged if you are interested! If that does sound like something you'd like, can you tell me (1) first / last name, (2) a URL you'd like included as a comment (personal website, GitHub profile, etc.)

@Kudusch
Copy link
Contributor Author

Kudusch commented Sep 26, 2022

Cool! I just opened the PR.

My name is Tim Schatto-Eckrodt and you could link to this page if this works out :)

@njlyon0 njlyon0 mentioned this issue Sep 27, 2022
7 tasks
@njlyon0
Copy link
Owner

njlyon0 commented Sep 28, 2022

Done!

Your function has been integrated and I added a new page to the website to demonstrate party_diagram. Thanks Tim!!

@njlyon0 njlyon0 closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants