don't animate into place if the component mounts open #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. It is a bit weird we are the first two to report that. |
|
I reckon it makes sense. Let me do some testing first.
Thanks!
|
|
Works good. I like it. Thank you very much @devtristan |
nkbt
added a commit
that referenced
this pull request
Dec 19, 2015
don't animate into place if the component mounts open
|
Published 1.5.0 https://github.com/nkbt/react-collapse/releases/tag/v1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue when initializing a Collapse element with content and isOpened=true, it would animate into place. It would initialize with a height of 0 and then expand from there. I didn't want that behavior, and I don't know why anybody would want that behavior, so I fixed it. This might be better suited as an optional feature, but again, don't know why people would want current behavior.