Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added react-height to readme #29

Merged
merged 1 commit into from
Jan 18, 2016
Merged

Added react-height to readme #29

merged 1 commit into from
Jan 18, 2016

Conversation

reintroducing
Copy link
Contributor

react-height was left out of the list of peerDependencies to install manually. I noticed this while installing react-collapse (warning for npm@3) so figured I'd just do a quick PR to update this.

@codecov-io
Copy link

Current coverage is 35.10%

Merging #29 into master will not affect coverage as of 08d136b

@@            master    #29   diff @@
=====================================
  Files           10     10       
  Stmts           94     94       
  Branches         0      0       
  Methods          0      0       
=====================================
  Hit             33     33       
  Partial          0      0       
  Missed          61     61       

Review entire Coverage Diff as of 08d136b

Powered by Codecov. Updated on successful CI builds.

nkbt added a commit that referenced this pull request Jan 18, 2016
Added react-height to readme
@nkbt nkbt merged commit f6223e6 into nkbt:master Jan 18, 2016
@nkbt
Copy link
Owner

nkbt commented Jan 18, 2016

Thank you!

@reintroducing
Copy link
Contributor Author

Sure thing :)

@just-boris
Copy link

just-boris commented May 27, 2016

Hello,

For me, it seems to have react-height as peer dependency is not a good idea. Usually, developers only put in their package.json only that packages, that they are actually using there. Unlike react-height which is not direct dependency, but now I have to care about its updates.

@nkbt could you change your mind and put react-height back into dev-dependency?

@nkbt
Copy link
Owner

nkbt commented Jun 9, 2016

Yeah I was thinking about it too. React-height seems to be react-collapse specific and not some sort of widely used library =). Makes sense to keep it as dep instead of peer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants