Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about smplify fitting process code #12

Closed
dytan opened this issue Oct 16, 2019 · 1 comment
Closed

question about smplify fitting process code #12

dytan opened this issue Oct 16, 2019 · 1 comment

Comments

@dytan
Copy link

dytan commented Oct 16, 2019

Noticed the '__ call__' function of smplify fitting process not call 'loss.backward()', and the vars stayed unchange after the process, seems typo here.
nkolot added a commit that referenced this issue Oct 16, 2019
@nkolot
address #12
a5c629f
@nkolot
Copy link
Owner

nkolot commented Oct 16, 2019

Yes, you are correct, I fixed it and pushed the changes. Thanks for pointing this out!

@nkolot nkolot closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dytan @nkolot