-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more than one write/read at a time (improve performance) #12
Comments
+1 I'm also sure that we can do better for performance. |
Do you have any good thoughts on this ? I'm really busy lately (with business) unfortunately :/ I've tried out a few things in the https://github.com/nkzawa/socket.io-stream/tree/fix/performance-issues branch. Feel free to check it out. Right now I feel that This is a massive issue, that would dramatically improve the library if we can solve it. So lets get it fixed ! :) |
I'm also busy recently because I'm taking a vacation and am traveling :) Anyway, it's better to take benchmark test first, IMO. |
so you back from vacation? |
I will check #13 again. |
I noticed that writing multiple times at a time makes the module incompatible to Stream API. BTW on upcoming socket.io v1.0, we can directly send a number of binary data at once. |
Right now since we toggle readable/writable everytime to synchronize reads/writes, I suspect that's damaging the performance of socket-io.stream.
Would be great if we could do something smarter rather than simply toggling. I think it would dramatically improve performance.
The text was updated successfully, but these errors were encountered: