Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation needs updating? #34

Closed
FrankMittelbach opened this issue May 23, 2018 · 3 comments
Closed

documentation needs updating? #34

FrankMittelbach opened this issue May 23, 2018 · 3 comments

Comments

@FrankMittelbach
Copy link

The text

As with all commands which have an optional argument as the last argument, if the
optional argument is omitted, any spaces following the final argument will be ignored.
Whereas, if the optional argument is present, any spaces following the optional
argument won’t be ignored. so \ordinal{section} ! will produce: 3rd! whereas
\ordinal{section}[m] ! will produce: 3rd !

isn't any longer true as a special version of \@ifnextchar is used

@vincentb1
Copy link
Owner

I think that you are right — I need to do some testing to confirm this new behaviour.

While scanning the code, I noted that \storeordinalnum, \storeNumberstringnum, \storeNUMBERstringnum such suchlikes are still using the old \@ifnextchar. Similarly \storeNUMBERstring is just a wrapper on top of \storeNUMBERstringnum, so it will also have the \@ifnextchar. OK, the \storeΩ commands — where Ω is whatever applicable — are probably less likely to be inserted in the flow of the text. @nlct is that just we forgot to fix them, or is it a desired behaviour to continue using the old one.

vincentb1 pushed a commit that referenced this issue Jun 18, 2018
See #34.

I also replaced ``3'' by ``\arabic{section}'' to be consistent with
the actual section number in which the example is given.

I took the opportunity to thank also bug reporters.
@vincentb1
Copy link
Owner

Hello,
Just to say that I have pushed some fix to the repo, still on branch version_3.05+.

@FrankMittelbach
Copy link
Author

looks good to me, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants