Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with right-shift in Gear rollsum. #12

Open
dbaarda opened this issue Feb 9, 2021 · 2 comments
Open

Problems with right-shift in Gear rollsum. #12

dbaarda opened this issue Feb 9, 2021 · 2 comments

Comments

@dbaarda
Copy link

dbaarda commented Feb 9, 2021

This implementation copies another implementation that uses a right-shift in its Gear rollsum. This has problems I reported here;

ronomon/deduplication#7

@nlfiedler
Copy link
Owner

I see that Joran closed the original issue, but regardless, I'm going to keep this open so that I can think about it more. I did not research this topic at all, merely read the paper once and translated the readily available implementation by Joran. Thank you for thinking about this and reporting it.

@dbaarda
Copy link
Author

dbaarda commented Feb 17, 2021

In case you are interested, I've also just finished some testing and analysis of chunker algorithms inspired by FastCDC here;

https://github.com/dbaarda/rollsum-chunking/blob/master/RESULTS.rst

The insights gained from this prompted me to post some other observations and recommendations when using that implementation of FastCDC here;

ronomon/deduplication#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants