Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Proposed DIGI implementation #7

Closed
wants to merge 4 commits into from
Closed

Proposed DIGI implementation #7

wants to merge 4 commits into from

Conversation

ny2cafuse
Copy link
Contributor

3 files modified, one being the readme just because the KGW line has been bugging me.

DIGI coded to kick in at block 180000 as a place holder. Can be changed to match a desired date and time.

-Fuse

Changed description to reflect the new algorithm.
Digishield implementation with 25% max adjustment at block 180000
Limit wallet version to latest DIGI update only.
@ny2cafuse
Copy link
Contributor Author

Checkpoints need to be added as well. I forgot to mention that.

@GeertJohan
Copy link
Contributor

Thanks for these changes. It looks like GetNextWorkRequired_DIGI is never called with these patches applied. A case is missing for when DiffMode = 4. Also I think the protocol version should not be increased, as the protocol will remain compatible. I will cherry pick some changes and squash to a single commit.

@ny2cafuse
Copy link
Contributor Author

You are correct. I added the Diffmode case statement, but forgot the call to the digi function. Thanks for catching that. I edited the code from Github instead of pulling it from my local repo. Should be complete other than that.

As far as protocol version goes, you need to be able to reject "valid" blocks from unupdated clients. If this can be done in a different way, so be it. I just know this is an easy way to reject blocks submitted by unupdated wallets using the old algo.

-Fuse

Forgot Diffmode function call to GetNextWorkRequired_DIGI.
@ny2cafuse
Copy link
Contributor Author

Added missing function call.

-Fuse

@ny2cafuse ny2cafuse closed this Jan 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants