Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop core::bits and merge content into core. #8

Closed
partim opened this issue Feb 11, 2019 · 3 comments
Closed

Drop core::bits and merge content into core. #8

partim opened this issue Feb 11, 2019 · 3 comments
Labels

Comments

@partim
Copy link
Member

partim commented Feb 11, 2019

Now that there is a separate domain::core crate, it feels like the bits module is an unnecessary extra indirection and could be dropped, merging all its contents into domain::core directly.

This would require some changes in use statements all over the code using domain::core. As a mitigation, we could keep bits for a while and re-export what already is in there now.

@partim partim added the discuss label Feb 11, 2019
@pusateri
Copy link

I think a flag day would be fine. Just announce when you're going to do it, make the change, and make a new release.

@partim
Copy link
Member Author

partim commented Feb 15, 2019

It’ll probably happen in 0.5.0 together with the changes I am working on to be able to use the crate in no_std environments (the octet-slices branch). While I am trying to do that this as transparently as possible, there’s bound to be some porting involved there, too.

@partim
Copy link
Member Author

partim commented Jun 25, 2019

Never mind the no_std thing. It feels to much of a burden for the regular use case which I imagine to be more common. So instead I just went ahead and merged bits in #32.

@partim partim closed this as completed Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants