Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip high number of BGP Communities: OpenBGPD example is different in content #73

Closed
marek22k opened this issue Jul 19, 2023 · 1 comment

Comments

@marek22k
Copy link

marek22k commented Jul 19, 2023

Hello, the OpenBGPD example is different from the other two. Is there a reason for that? Which one is correct?
I have highlighted the difference in pseudo code below.

BIRD, Junos, Arista

if ( ( bgp_community.length + bgp_ext_community.length + bgp_large_community.length ) >= 100 ) {
    bgp_community.delete_all();
    bgp_ext_community.delete_all();
    bgp_large_community.delete_all();
}

OpenBGPD:

if ( bgp_community.length >= 100 ) {
    bgp_community.delete_all();
}
if ( bgp_ext_community.length >= 100 ) {
    bgp_community.delete_all();
}
if ( bgp_large_community.length >= 100 ) {
    bgp_community.delete_all();
}

Ping on maintainers: @job @rodecker

@job
Copy link
Member

job commented Jul 19, 2023

OpenBGPd doesn’t support cumulatively counting the instances of extended + classic + large communities. I think the goal is to impose some kind of upper bound, not necessarily being precise.

@job job closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants