Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log confirm topic messages #3

Closed
trym-b opened this issue Jul 10, 2023 · 2 comments · Fixed by #43
Closed

Log confirm topic messages #3

trym-b opened this issue Jul 10, 2023 · 2 comments · Fixed by #43
Labels
enhancement New feature or request

Comments

@trym-b
Copy link
Contributor

trym-b commented Jul 10, 2023

Motivation

The current design proposal only validates the entries in the reject topic, but the messages sent to the confirm topic might still be of interest.

Feature

Logging at least the relevant results from the confirm topic could be helpful when debugging.
@trym-b trym-b added the enhancement New feature or request label Jul 10, 2023
@maeb
Copy link
Member

maeb commented Nov 6, 2023

I suggest adding a third command to hermetic that listens to the confirm topic and logs the relevant messages.

andrbo added a commit that referenced this issue Apr 4, 2024
@andrbo
refactor: Introduce sub-commands for the verify command
e94a5e3 
This commit restructures the verify command to include a 'reject' sub-command.
The current verify command supports listening to the reject messages and is therefore moved to the reject sub-command.
To address issue #3, this refactoring is meant to
make ready for the inclusion of a 'confirm' sub-command.
andrbo added a commit that referenced this issue Apr 4, 2024
@andrbo
feat: Mvp implementation a confirm sub-command for the verify command
894ab80 
This commit is meant as a start to solve issue #3.
It introduces a confirm sub-command to the verify command which will be used to listen
to messages from a confirm topic.
@andrbo andrbo mentioned this issue Apr 4, 2024
Merged
andrbo added a commit that referenced this issue Apr 5, 2024
@andrbo
feat: Mvp implementation a confirm sub-command for the verify command
883ed4c 
This commit is meant as a start to solve issue #3.
It introduces a confirm sub-command to the verify command which will be used to listen
to messages from a confirm topic.
andrbo added a commit that referenced this issue Apr 8, 2024
@andrbo
refactor: Introduce sub-commands for the verify command
4cdb03d 
This commit restructures the verify command to include a 'reject' sub-command.
The current verify command supports listening to the reject messages and is therefore moved to the reject sub-command.
To address issue #3, this refactoring is meant to
make ready for the inclusion of a 'confirm' sub-command.
andrbo added a commit that referenced this issue Apr 8, 2024
@andrbo
refactor: Introduce sub-commands for the verify command
596bbf5 
This commit restructures the verify command to include a 'reject' sub-command.
The current verify command supports listening to the reject messages and is therefore moved to the reject sub-command.
To address issue #3, this refactoring is meant to
make ready for the inclusion of a 'confirm' sub-command.
andrbo added a commit that referenced this issue Apr 8, 2024
@andrbo
feat: Mvp implementation a confirm sub-command for the verify command
3475992 
This commit is meant as a start to solve issue #3.
It introduces a confirm sub-command to the verify command which will be used to listen
to messages from a confirm topic.
andrbo added a commit that referenced this issue Apr 8, 2024
@andrbo
feat: Mvp implementation a confirm sub-command for the verify command
c4fa680 
This commit is meant as a start to solve issue #3.
It introduces a confirm sub-command to the verify command which will be used to listen
to messages from a confirm topic.
andrbo added a commit that referenced this issue Apr 8, 2024
@andrbo
feat: Mvp implementation a confirm sub-command for the verify command
9348603 
This commit is meant as a start to solve issue #3.
It introduces a confirm sub-command to the verify command which will be used to listen
to messages from a confirm topic.
@andrbo andrbo closed this as completed in #43 Apr 8, 2024
@andrbo andrbo reopened this Apr 8, 2024
andrbo added a commit that referenced this issue Apr 10, 2024
@andrbo
refactor: Introduce sub-commands for the verify command
92f105a 
This commit restructures the verify command to include a 'reject' sub-command.
The current verify command supports listening to the reject messages and is therefore moved to the reject sub-command.
To address issue #3, this refactoring is meant to
make ready for the inclusion of a 'confirm' sub-command.
andrbo added a commit that referenced this issue Apr 10, 2024
@andrbo
feat: Mvp implementation a confirm sub-command for the verify command
e451e7f 
This commit is meant as a start to solve issue #3.
It introduces a confirm sub-command to the verify command which will be used to listen
to messages from a confirm topic.
andrbo added a commit that referenced this issue Apr 10, 2024
@andrbo
refactor: Introduce sub-commands for the verify command
2c42967 
This commit restructures the verify command to include a 'reject' sub-command.
The current verify command supports listening to the reject messages and is therefore moved to the reject sub-command.
To address issue #3, this refactoring is meant to
make ready for the inclusion of a 'confirm' sub-command.
andrbo added a commit that referenced this issue Apr 10, 2024
@andrbo
feat: Mvp implementation a confirm sub-command for the verify command
1b9aea0 
This commit is meant as a start to solve issue #3.
It introduces a confirm sub-command to the verify command which will be used to listen
to messages from a confirm topic.
@andrbo andrbo mentioned this issue Apr 10, 2024
Merged
@maeb
Copy link
Member

maeb commented Jul 24, 2024

Closed by #44

@maeb maeb closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for listening to confirm-topic nlnwa/hermetic
3 participants
@maeb @andrbo @trym-b