Log confirm messages #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrbo
force-pushed
the
feat/log_confirm_messages
branch
from
5e3c4c4
to
94335f2
Compare
trym-b
reviewed
Apr 11, 2024
andrbo
force-pushed
the
feat/log_confirm_messages
branch
2 times, most recently
from
2b169c4
to
7fa66ce
Compare
|
Looks like you have a few CI errors, not sure if you have seen them or not: I'll wait with the next round of review until those errors have been fixed, sounds good @andrbo ? |
andrbo
force-pushed
the
feat/log_confirm_messages
branch
from
7fa66ce
to
c648c08
Compare
trym-b
reviewed
May 7, 2024
andrbo
force-pushed
the
feat/log_confirm_messages
branch
from
c648c08
to
dfdd078
Compare
trym-b
approved these changes
May 13, 2024
andrbo
force-pushed
the
feat/log_confirm_messages
branch
from
dfdd078
to
d4ab454
Compare
As both verify reject/confirm is similar, a refactor has been made to allow for sharing of code used by both. - Setup of the kafka reader been moved to the cmd argument parsing, to simplify function calls down the line, and hopefully making it easier to mock in tests. - Changed the groupID in the kafka reader config to separate between verify confirm and verify reject - Now supplying context to the read functions, for a graceful shutdown when running i within a container.
Heavily inspired by the verify reject command this command now prints the messages from confirm-topic.
maeb
force-pushed
the
feat/log_confirm_messages
branch
from
3c16a01
to
3a4a4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve #3 , by logging messages from the
confirm-topic.This pull request will add loggin of the
identifierandpathfrom the message.