Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ${iis-site-name} for ASP.NET Core, move IHostingEnvironment.EnvironmentName to ${aspnet-environment} #125

Merged
merged 2 commits into from
Mar 31, 2017
Merged

fix ${iis-site-name} for ASP.NET Core, move IHostingEnvironment.EnvironmentName to ${aspnet-environment} #125

merged 2 commits into from
Mar 31, 2017

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Mar 30, 2017 •
edited
Loading

supersedes #121

@304NotModified 304NotModified mentioned this pull request Mar 30, 2017
Closed
@grokky1 @304NotModified
iis-site-name should return app name in ASP.NET Core
e3f0ac4 
For ASP.NET Core:

IHostingEnvironment.EnvironmentName = "Development", "Production", "Staging", etc.
IHostingEnvironment.ApplicationName = the app name

The layout renderer for "iis-site-name" is incorrectly rendering the first instead of the second.
@grokky1 @304NotModified
Add aspnet-environment
850f479
@codecov-io
Copy link

codecov-io commented Mar 31, 2017 •
edited
Loading

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   59.07%   59.07%           
=======================================
  Files          24       24           
  Lines         303      303           
  Branches       75       75           
=======================================
  Hits          179      179           
  Misses         90       90           
  Partials       34       34
Impacted Files Coverage Δ
...e/LayoutRenderers/IISInstanceNameLayoutRenderer.cs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab8049...850f479. Read the comment docs.

@304NotModified 304NotModified merged commit 8b5d172 into master Mar 31, 2017
@304NotModified 304NotModified deleted the grokky1-patch-1 branch March 31, 2017 09:44
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@304NotModified @codecov-io @snakefoot @grokky1