Fix ${tempdir} and ${nlogdir} if both have dir and file. #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304NotModified
force-pushed
the
fix-tempdir-layoutrenderer
branch
from
62d75e9
to
13c257e
Compare
304NotModified
changed the title
304NotModified
force-pushed
the
fix-tempdir-layoutrenderer
branch
from
13c257e
to
dc4047b
Compare
according to docs both should be appended removed code duplication
304NotModified
force-pushed
the
fix-tempdir-layoutrenderer
branch
from
dc4047b
to
0f3de23
Compare
304NotModified
force-pushed
the
fix-tempdir-layoutrenderer
branch
from
5f51f0d
to
3adff48
Compare
Current coverage is 77% (diff: 100%)@@ master #1635 diff @@
==========================================
Files 272 273 +1
Lines 16670 16646 -24
Methods 2649 2650 +1
Messages 0 0
Branches 1839 1833 -6
==========================================
+ Hits 12713 12738 +25
+ Misses 3522 3472 -50
- Partials 435 436 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to docs both should be appended
also removed code duplication
This change is