FileTarget: Add WriteFooterOnArchivingOnly parameter.

[bhaeussermann]

Fix #1602

---

This change is

[codecov-io]

Current coverage is 78% (diff: 79%)

Merging #1641 into master will decrease coverage by 2%

@@             master      #1641   diff @@
==========================================
  Files           273        273          
  Lines         16696      16667    -29   
  Methods        2652       2653     +1   
  Messages          0          0          
  Branches       1839       1836     -3   
==========================================
- Hits          13268      12958   -310   
- Misses         3009       3285   +276   
- Partials        419        424     +5   

Powered by Codecov. Last update 43eca98...0fa4e1e

[304NotModified]

Cool! Thanks !

Not sure about the property name though. What about "onlyFooterOnArchives" ?

[bhaeussermann]

Not sure about the property name though. What about "onlyFooterOnArchives" ?

Well, normally the footer is written in the following three cases:

1. The target is closed,
2. The file is archived,
3. We are starting to write to a different file name (without explicit archiving).

If the option claimed to write the footer upon archiving only, that would suggest that the footer would not be written for case (3) above either, which is probably not what we want.

[304NotModified]

If the option claimed to write the footer upon archiving only, that would suggest that the footer would not be written for case (3) above either, which is probably not what we want.

Well I was think we would like that, because we never known if we would write the file again.

Well, normally the footer is written in the following three cases:

1. The target is closed,
2. The file is archived,
3. We are starting to write to a different file name (without explicit archiving).

With WriteFooterOnTargetClose =false I'm not sure if a footer would be written in case 3.

[bhaeussermann]

Well I was think we would like that, because we never known if we would write the file again.

Makes sense. I changed the property to WriteFooterOnArchivingOnly.

[304NotModified]

👍

[304NotModified]

oops merge conflict. Could you fix this?

(PS if you create a branch on the NLog repos, I could also easily fix the merge conflict.)

[304NotModified]

Could you add this to the wiki? Will release it in 4.3.9.

Thanks!

[bhaeussermann]

Could you add this to the wiki?

Done.