Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileTarget on Xamarin: Remove mutex usage for Xamarin 'cause of runtime exceptions #1676

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Oct 4, 2016

Fixes #1666

Unfortunately, Xamarin Android and Xamarin iOS don't support mutexes (see https://github.com/mono/mono/blob/3a9e18e5405b5772be88bfc45739d6a350560111/mcs/class/corlib/System.Threading/Mutex.cs#L167)


This change is Reviewable

@304NotModified 304NotModified added this to the 4.3.10 milestone Oct 4, 2016
@304NotModified 304NotModified changed the title remove mutex usage for Xamarin Fix FileTarget on Xamarin: Remove mutex usage for Xamarin 'cause of runtime exceptions Oct 4, 2016
@codecov-io
Copy link

codecov-io commented Oct 5, 2016

Current coverage is 80% (diff: 100%)

Merging #1676 into master will decrease coverage by <1%

@@             master      #1676   diff @@
==========================================
  Files           273        273          
  Lines         16727      16727          
  Methods        2660       2660          
  Messages          0          0          
  Branches       1843       1843          
==========================================
- Hits          13406      13394    -12   
  Misses         2902       2902          
- Partials        419        431    +12   

Sunburst

Powered by Codecov. Last update 4e63930...993845d

@304NotModified 304NotModified added the bug Bug report / Bug fix label Oct 5, 2016
@304NotModified 304NotModified merged commit 48daa87 into master Oct 5, 2016
@304NotModified 304NotModified deleted the no-mutex-on-xamarin branch October 5, 2016 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants