Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: InternalLogger should only allocate params-array when needed #1702

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Performance: InternalLogger should only allocate params-array when needed #1702

merged 2 commits into from
Oct 11, 2016

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 10, 2016 •
edited by 304NotModified
Loading

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Oct 10, 2016 •
edited
Loading

Current coverage is 80% (diff: 100%)

Merging #1702 into master will increase coverage by <1%

@@             master      #1702   diff @@
==========================================
  Files           274        274          
  Lines         16912      16983    +71   
  Methods        2669       2687    +18   
  Messages          0          0          
  Branches       1876       1893    +17   
==========================================
+ Hits          13543      13622    +79   
+ Misses         2936       2930     -6   
+ Partials        433        431     -2

Sunburst

Powered by Codecov. Last update 639b40f...35b2d8d

@304NotModified
Copy link
Member

Please also extend the unit tests.

@304NotModified
Copy link
Member

Thx in advance!

@304NotModified 304NotModified merged commit f717b5f into NLog:master Oct 11, 2016
@304NotModified 304NotModified added this to the 4.3.10 milestone Oct 11, 2016
@304NotModified
Copy link
Member

Thanks!!

@304NotModified 304NotModified changed the title InternalLogger should only allocate params-array when needed Performance: InternalLogger should only allocate params-array when needed Oct 11, 2016
@304NotModified
Copy link
Member

This has been published, a lot of @snakefoot in 4.3.10!!! Thanks 💯 👍

@snakefoot snakefoot deleted the InternalLoggerTrace branch October 11, 2016 20:25
@snakefoot
Copy link
Contributor Author

Yes it has been some busy weeks ;). Learned a lot about the NLog-framework. Also excited about #1693 and #1694

@snakefoot snakefoot mentioned this pull request Dec 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
4.3.10
Development

Successfully merging this pull request may close these issues.
3 participants
@snakefoot @codecov-io @304NotModified