Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions: Try interpreting first as non-string value #1730

Merged
merged 3 commits into from
Nov 7, 2016

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Oct 29, 2016

Fixes #1727

11 < '100' when wrong was the common type was a string. Now both the string is tried as int, as the left hand is a int


This change is Reviewable

@304NotModified 304NotModified changed the title Added test for #1727 Comparison in condition, prefer non-string values and try first Oct 29, 2016
@304NotModified 304NotModified added the bug Bug report / Bug fix label Oct 29, 2016
@304NotModified 304NotModified added this to the 4.3.11 milestone Oct 29, 2016
@304NotModified 304NotModified force-pushed the extra-test-numberic-comp branch 2 times, most recently from 96331de to 0108a0e Compare October 29, 2016 23:57
@codecov-io
Copy link

codecov-io commented Oct 30, 2016

Current coverage is 80% (diff: 99%)

Merging #1730 into master will decrease coverage by <1%

@@             master      #1730   diff @@
==========================================
  Files           274        274          
  Lines         17066      17112    +46   
  Methods        2698       2703     +5   
  Messages          0          0          
  Branches       1910       1916     +6   
==========================================
+ Hits          13698      13730    +32   
  Misses         2932       2932          
- Partials        436        450    +14   

Sunburst

Powered by Codecov. Last update 258bb8f...c25db1f

@304NotModified 304NotModified merged commit 8e36748 into master Nov 7, 2016
@304NotModified 304NotModified deleted the extra-test-numberic-comp branch November 7, 2016 18:48
@304NotModified 304NotModified changed the title Comparison in condition, prefer non-string values and try first Conditions: Try interpreting first as non-string value Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants