Fix: include ignoreErrors attribute not working for non-existent file #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to include a non-existant file with ignoreErrors set to true and exceptions turned on verify it does not throw an exception. NLog#2094
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
=======================================
+ Coverage 81% 81% +<1%
=======================================
Files 289 289
Lines 19943 19948 +5
Branches 2359 2360 +1
=======================================
+ Hits 16190 16223 +33
+ Misses 3147 3123 -24
+ Partials 606 602 -4 |
304NotModified
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to include a non-existant file with
ignoreErrors set to true and exceptions turned on
verify it does not throw an exception.
#2094