FileTarget: Support byte order mark (optional) #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will review soon! |
Codecov Report
@@ Coverage Diff @@
## master #2456 +/- ##
========================================
Coverage ? 81%
========================================
Files ? 322
Lines ? 23159
Branches ? 2874
========================================
Hits ? 18873
Misses ? 3538
Partials ? 748 |
304NotModified
changed the title
|
nice! Could you please add some docs to https://github.com/NLog/NLog/wiki/File-Target? Please add "introduced in NLog 4.5" - thanks! |
|
Thank you. I added description for new parameter to https://github.com/NLog/NLog/wiki/File-Target |
304NotModified
added
the
documentation done
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added ability to write byte order mark. fixes #26