SpecialFolderLayoutRenderer honor file and dir #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, looks good to me. Could you create some unit tests for this feature? |
|
Ok. There isn't currently a unit test for this renderer, but I'll add one. It looks like baseDir renderer has the same issue, so I'll also add a fix for it to this PR. |
added 2 commits
May 12, 2014 21:38
Allows for use of both parameters. Updates unit tests to cover use of both parameters
|
@Xharze I've added unit tests for SpecialFolderLayoutRenderer and also corrected BaseDirLayoutRenderer which had similar behavior in which file worked or dir worked but not both. I also updated it's unit test. If you prefer I squash these into a single commit, let me know. |
ghost
added this to the
ghost
pushed a commit
that referenced
this pull request
May 22, 2014
SpecialFolderLayoutRenderer honor file and dir
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SpecialFolderLayoutRenderer to combine the special folder with both file and directory if specified.