Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineEndingMode Changed to Immutable Class #473

Merged
1 commit merged into from
Dec 29, 2014
Merged

LineEndingMode Changed to Immutable Class #473

1 commit merged into from
Dec 29, 2014

Conversation

ie-zero
Copy link
Contributor

@ie-zero ie-zero commented Dec 20, 2014

Converted LineEndingMode from enumeration to sealed immutable class
which allows us to group LineEnding and NewLineChars properties in
FileTarget under a single entity.

Converted LineEndingMode from enumeration to sealed immutable class
which allows us to group LineEnding and NewLineChars properties in
FileTarget under a single entity.
@ghost
Copy link

ghost commented Dec 29, 2014

Thanks for the pull request. Looks good to me, I'll merge it

@ghost ghost added this to the 4.0 milestone Dec 29, 2014
@ghost ghost added the enhancement Improvement on existing feature label Dec 29, 2014
ghost pushed a commit that referenced this pull request Dec 29, 2014
LineEndingMode Changed to Immutable Class
@ghost ghost merged commit 8328fac into NLog:v4.0 Dec 29, 2014
@ie-zero ie-zero deleted the LineEndingMode_ChangedToClass branch December 30, 2014 11:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant