-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wcf receiver client #874
Wcf receiver client #874
Conversation
The Client Postifx are now the facade
This reverts commit fcca6c6.
The base class allows for the code duplication to removed. Also, it allows for the inheriting class to invoke the correct channel from the ClientBase<TService>, so WCF should be happy at runtime, too. Added deprecation to ILogReceiverClient and its implementation in favor of the other two interfaces. Added deprecation to the LogReceiverWebServiceTarget's protected method that returned a concrete class in favor of a new method that returns an interface.
1dd7e7f
to
71e7bfe
Compare
I'm pretty sure that the generic clientbase won't work. :( See unit tests |
I saw that error. I don't think that's an issue. I've seen errors like that On Monday, August 24, 2015, Julian Verdurmen notifications@github.com
Sent from Gmail Mobile |
Well then it Isn't backwards compatible? |
That's not the same error. I'll investigate tonight. On Monday, August 24, 2015, Julian Verdurmen notifications@github.com
Sent from Gmail Mobile |
Constructor calls were all going to the base constructor.
Hooray! The issue was the call to the base constructor. The unit tests passed. I was going to look through tonight to see if there are any compatibility issues, but it looks hopeful. No change to the app.config or unit tests. It was just in the WcfLogReceiverClient constructors. |
Good work! |
The documentation looks good to me. Also, the following might be compatibility concerns:
Lastly, there is a small amount of code duplication for the SilverLight in each of the WcfLogReceiverClient implementations. I think this can be resolved by implementing a similar base class like the WcfLogReceiverClient. Let me know if there's anything else you need. |
To be sure:
This is a compatibility issue vs (only) NLog 3.2?
This is a compatibility issue vs (only) NLog 4.0?
Yes, I expected that. But I think we improved the compatibly from 3.2 to 4.1 (4.0 was a mistake) |
|
Can't we fix the first one with a rename? |
Rename client to facade client? On Thursday, August 27, 2015, Julian Verdurmen notifications@github.com
Sent from Gmail Mobile |
rename |
That won't fix it. It's a binary incompatibility because we changed the On Thursday, August 27, 2015, Julian Verdurmen notifications@github.com
Sent from Gmail Mobile |
Finally managed to take a look at this. I tried it in my test scenarios and found no issues. |
This should supersede #821.
Add some unit tests(or run the ones available)