Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Exception is thrown when archiving is enabled #966

Merged
merged 7 commits into from
Oct 18, 2015
Merged

Fix: Exception is thrown when archiving is enabled #966

merged 7 commits into from
Oct 18, 2015

Conversation

304NotModified
Copy link
Member

Fixes #957

@codecov-io
Copy link

Current coverage is 70.52%

Merging #966 into master will increase coverage by +0.11% as of 28cb7f0

@@            master    #966   diff @@
======================================
  Files          263     263       
  Stmts        14743   14753    +10
  Branches      1603    1604     +1
  Methods          0       0       
======================================
+ Hit          10382   10404    +22
+ Partial        394     393     -1
+ Missed        3967    3956    -11

Review entire Coverage Diff as of 28cb7f0

Uncovered Suggestions

  1. +0.08% via ...oredConsoleTarget.cs#232...244
  2. +0.08% via ...c/NLog/LogFactory.cs#180...191
  3. +0.07% via ...anceCounterTarget.cs#308...318
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added bug Bug report / Bug fix has unittests labels Oct 18, 2015
@304NotModified 304NotModified added this to the 4.2 milestone Oct 18, 2015
304NotModified added a commit that referenced this pull request Oct 18, 2015
@304NotModified
Merge pull request #966 from NLog/Exception-is-thrown-when-archiving-…
ed8a606 
…is-enabled

Fix: Exception is thrown when archiving is enabled
@304NotModified 304NotModified merged commit ed8a606 into master Oct 18, 2015
@304NotModified 304NotModified deleted the Exception-is-thrown-when-archiving-is-enabled branch October 22, 2015 19:04
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@304NotModified @codecov-io