Made UI respect order of attributes in config #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they were specified in in config is reflected in the UI.
|
This one is also awesome, why hasn't it been merged? |
ghost
added this to the
|
The server-side changes look fine, as much as I hate pre-allocation, would have opted for sorting a list of tuples, I am willing to merge the changes. @amadanmath: Do you have any opinion on the client-side changes? |
|
I could certainly update it to avoid pre-allocation, if you'd prefer... |
|
@duncanka: It would certainly be appreciated. Pre-allocation can lead to nasty bugs further down the line. |
|
Done. It's now displaying that there are merge conflicts; I think I may have accidentally created them by letting Emacs strip whitespace. If those are the source of the conflicts, sorry about that. |
amadanmath
pushed a commit
that referenced
this pull request
Nov 6, 2014
Made UI respect order of attributes in config
|
Stripping whitespace is not a problem, just beware of sneaky tabs. :) Thanks for the contrib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that for my annotation project, annotators wanted to see the attribute options in a specific order (they were on a spectrum). This change wasn't a particularly drastic one, and it seemed like it might be useful to others, as well.