Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolarStereographicGridDefinition.EnumerateGridPoints Not Implemented Exception - when reader.GetDatasetValues is called #5

Open
AquaNerd opened this issue Feb 11, 2022 · 5 comments

Comments

@AquaNerd
Copy link

I am getting a not implemented exception while using the GetDatasetsValues. Mostly to test how complete the library is and what yet needs to be implemented to make it fully functional for my usecase. Are there plans to complete some of this work in the near future? And am I using it correctly? ReadMessages and ReadAllDatasets seems to do most of what I need but now wondering if those are iterating through all the data completely. I would like to help, but interested in your feedback.

image

@nmangue
Copy link
Owner

nmangue commented Feb 13, 2022

The way you read the data is ok. However there are many ways to encode data values in a grib file. It seems that the template used by your dataset is not yet supported

Could you provide the full stack trace and the value of DataSet.DataRepresentationSection.TemplateNumber ?
If possible, could you also share the file you are reading ?

@AquaNerd
Copy link
Author

@nmangue thanks for getting back to me so quickly. Here is where I am pulling the grib2 files from. https://nomads.ncep.noaa.gov/pub/data/nccf/com/pcpanl/prod/

An example file out of those are https://nomads.ncep.noaa.gov/pub/data/nccf/com/pcpanl/prod/pcpanl.20220211/st4_conus.2022021114.01h.grb2

@AquaNerd
Copy link
Author

@nmangue I am finding out that the original not implemented exception is due to the contents of the file include using the polarStereographicGridDefinition template which here is not yet implemented.

public override IEnumerable<Coordinate> EnumerateGridPoints() => throw new NotImplementedException();

I assume that was put there as a placeholder for the point when you ran into a need to implement it. As in, you didn't have example data to use in order to set it up. Correct?

@nmangue
Copy link
Owner

nmangue commented Feb 16, 2022

That is correct !
Would you try to implement this functionality ? You can use the NetCDF Java implementation as a reference : Grib2Gds.java@983

@AquaNerd
Copy link
Author

AquaNerd commented Feb 16, 2022

@nmangue in due time. But for my use case, I am limited on time. I guess I will keep an eye out if you or someone else beats me to it.

That is correct ! Would you try to implement this functionality ? You can use the NetCDF Java implementation as a reference : Grib2Gds.java@983

Also there is a bit more to it then just copy pasting into c# code. I have not dug into it far enough to determine what is comparable to the projection interface and AbstractProjection base class that is used for the stereographic projection.

@AquaNerd AquaNerd changed the title Not Implemented Exception - GetDatasetValues PolarStereographicGridDefinition.EnumerateGridPoints Not Implemented Exception - when reader.GetDatasetValues is called Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants