Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert typed array code #42

Merged
merged 3 commits into from
Mar 28, 2016
Merged

Revert typed array code #42

merged 3 commits into from
Mar 28, 2016

Conversation

nmrugg
Copy link
Collaborator

@nmrugg nmrugg commented Mar 28, 2016

Seeing if this will pass build.

This reverts commit fa25f54.
lzma_worker.js
Original size: 112941 bytes (110.3 KB)
Minified size: 24263 bytes (23.7 KB)
Compression:   4.6549 x smaller
Gzipped size:  9470 bytes (9.2 KB)
Gzipped ratio: 11.9262 x smaller

lzma-c.js
Original size: 85848 bytes (83.8 KB)
Minified size: 18442 bytes (18.0 KB)
Compression:   4.6550 x smaller
Gzipped size:  7484 bytes (7.3 KB)
Gzipped ratio: 11.4709 x smaller

lzma-d.js
Original size: 32429 bytes (31.7 KB)
Minified size: 7128 bytes (7.0 KB)
Compression:   4.5495 x smaller
Gzipped size:  3131 bytes (3.1 KB)
Gzipped ratio: 10.3574 x smaller

lzma.js
Original size: 6642 bytes (6.5 KB)
Minified size: 1761 bytes (1.7 KB)
Compression:   3.7717 x smaller
Gzipped size:  776 bytes (0.76 KB)
Gzipped ratio: 8.5593 x smaller
@addaleax
Copy link
Collaborator

The TextEncoder/TextDecoder change should not really have any influence on Node.js. But yes, feel free to merge this when it passes, I’ll set up the v3 branch then.

@nmrugg
Copy link
Collaborator Author

nmrugg commented Mar 28, 2016

I thought so too, and Travis agrees. I was just curious.

I agree that we don't need to support 0.8 any more, but I am also wondering about the browser support. I don't know all of the browsers we should (or do) support. In the past, I think it's been pretty robust. I tested earlier versions on IE6 (mainly just for fun). It would be nice to keep wide support unless there is a good reason to drop old browsers (which there might be).

@nmrugg
Copy link
Collaborator Author

nmrugg commented Mar 28, 2016

Oh, and I also noticed that the advanced demo is having problems.

@addaleax
Copy link
Collaborator

I guess that must be #39 – revert that one too, then.

@nmrugg
Copy link
Collaborator Author

nmrugg commented Mar 28, 2016

Yeah, I think you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants