Datawallet modifications are not executed in the right order and wrong objects are deleted #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoenig134
added
wip
jkoenig134
changed the title
Codecov ReportAttention: Patch coverage is
|
…' of github.com:nmshd/runtime into fix/execute-datawallet-modifications-in-the-right-order
jkoenig134
removed
the
wip
jkoenig134
requested review from
sebbi08,
slavistan,
Magnus-Kuhn,
britsta,
Milena-Czierlinski and
stnmtz
|
@Siolto FYI, we should be able to test this soon in the App :) |
stnmtz
previously approved these changes
Oct 2, 2024
tnotheis
requested changes
Oct 2, 2024
packages/transport/src/modules/sync/DatawalletModificationsProcessor.ts
Outdated
Show resolved
Hide resolved
packages/transport/test/modules/sync/SyncController.ordered.test.ts
Outdated
Show resolved
Hide resolved
stnmtz
reviewed
Oct 2, 2024
packages/transport/src/modules/sync/DatawalletModificationsProcessor.ts
Outdated
Show resolved
Hide resolved
stnmtz
reviewed
Oct 2, 2024
…' of github.com:nmshd/runtime into fix/execute-datawallet-modifications-in-the-right-order
tnotheis
approved these changes
Oct 2, 2024
jkoenig134
deleted the
fix/execute-datawallet-modifications-in-the-right-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
When we first have written the Datawallet logic we were convinced that we can execute modifications in the order
creates -> updates -> deletes -> cacheChanges.With the Relationship termination now more in use we have encountered bugs with this approach. This PR changes the behavior to run the modifications (except cacheChanges) in the exact order the arrived.
Some of the optimizations done here will be implemented by the backbone team later, but should not break as soon the optimize it.