Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #133. There was a minor logic error in path extraction around manifold mesh boundaries. I sometimes tried to trace back along the virtual boundary loop faces that
ManifoldSurfaceMesh
uses, which caused some errors. Adding theisBoundaryLoop
check to line 123 ofexact_geodesics.cpp
fixes the bug.Also modifies
TraceGeodesicResult
to return the length of the traced path.